[ros-diffs] [cgutman] 40909: - Use FindOnLinkInterface to get the interface - Return NULL if TCPContext is NULL (which means we don't have a valid IP address) - Should fix a crash when using multiple NICs but they still won't work (DHCP bug?)

[cgutman at svn.reactos.org]

Author: cgutman
Date: Wed May 13 05:16:30 2009
New Revision: 40909

URL: http://svn.reactos.org/svn/reactos?rev=40909&view=rev
Log:
 - Use FindOnLinkInterface to get the interface
 - Return NULL if TCPContext is NULL (which means we don't have a valid IP address)
 - Should fix a crash when using multiple NICs but they still won't work (DHCP bug?)

Modified:
    trunk/reactos/lib/drivers/ip/transport/tcp/if.c

Modified: trunk/reactos/lib/drivers/ip/transport/tcp/if.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/transport/tcp/if.c?rev=40909&r1=40908&r2=40909&view=diff
==============================================================================
--- trunk/reactos/lib/drivers/ip/transport/tcp/if.c [iso-8859-1] (original)
+++ trunk/reactos/lib/drivers/ip/transport/tcp/if.c [iso-8859-1] Wed May 13 05:16:30 2009
@@ -74,7 +74,7 @@
 			      OSK_UINT FindType,
 			      OSK_SOCKADDR *ReqAddr,
 			      OSK_IFADDR *Interface ) {
-    PNEIGHBOR_CACHE_ENTRY NCE;
+    PIP_INTERFACE IF;
     IP_ADDRESS Destination;
     struct sockaddr_in *addr_in = (struct sockaddr_in *)ReqAddr;
 
@@ -90,23 +90,20 @@
 
     TI_DbgPrint(DEBUG_TCPIF,("Address is %x\n", addr_in->sin_addr.s_addr));
 
-    NCE = RouteGetRouteToDestination(&Destination);
+    IF = FindOnLinkInterface(&Destination);
 
-    if( !NCE || !NCE->Interface ) {
-	TI_DbgPrint(DEBUG_TCPIF,("no neighbor cache or no interface (%x %x)\n",
-			       NCE, NCE ? NCE->Interface : 0));
-	return NULL;
+    if (!IF || !IF->TCPContext) {
+        /* TCPContext can be NULL if we don't have an IP address yet */
+        TI_DbgPrint(DEBUG_TCPIF, ("No interface or TCP context (%x) (%x)\n",
+                                  IF, IF ? IF->TCPContext : 0));
+        return NULL;
     }
 
-    TI_DbgPrint(DEBUG_TCPIF,("NCE: %x\n", NCE));
-    TI_DbgPrint(DEBUG_TCPIF,("NCE->Interface: %x\n", NCE->Interface));
-    TI_DbgPrint(DEBUG_TCPIF,("NCE->Interface->TCPContext: %x\n",
-			   NCE->Interface->TCPContext));
+    addr_in = (struct sockaddr_in *)
+	((POSK_IFADDR)IF->TCPContext)->ifa_addr;
 
-    addr_in = (struct sockaddr_in *)
-	((POSK_IFADDR)NCE->Interface->TCPContext)->ifa_addr;
     TI_DbgPrint(DEBUG_TCPIF,("returning addr %x\n", addr_in->sin_addr.s_addr));
 
-    return NCE->Interface->TCPContext;
+    return IF->TCPContext;
 }