[ros-diffs] [tkreuzer] 50096: [HAL] Convert while (TRUE); to ASSERT(FALSE); on unimplemented pathes.

tkreuzer at svn.reactos.org tkreuzer at svn.reactos.org
Wed Dec 22 14:31:40 UTC 2010


Author: tkreuzer
Date: Wed Dec 22 14:31:39 2010
New Revision: 50096

URL: http://svn.reactos.org/svn/reactos?rev=50096&view=rev
Log:
[HAL]
Convert while (TRUE); to ASSERT(FALSE); on unimplemented pathes.

Modified:
    trunk/reactos/hal/halx86/generic/timer.c

Modified: trunk/reactos/hal/halx86/generic/timer.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/timer.c?rev=50096&r1=50095&r2=50096&view=diff
==============================================================================
--- trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/timer.c [iso-8859-1] Wed Dec 22 14:31:39 2010
@@ -72,7 +72,7 @@
     /* Disable interrupts */
     Flags = __readeflags();
     _disable();
-    
+
     /* Program the PIT for binary mode */
     TimerControl.BcdMode = FALSE;
 
@@ -85,13 +85,13 @@
      */
     TimerControl.OperatingMode = PitOperatingMode2;
     TimerControl.Channel = PitChannel0;
-    
+
     /* Set the access mode that we'll use to program the reload value */
     TimerControl.AccessMode = PitAccessModeLowHigh;
-    
+
     /* Now write the programming bits */
     __outbyte(TIMER_CONTROL_PORT, TimerControl.Bits);
-    
+
     /* Next we write the reload value for channel 0 */
     __outbyte(TIMER_CHANNEL0_DATA_PORT, RollOver & 0xFF);
     __outbyte(TIMER_CHANNEL0_DATA_PORT, RollOver >> 8);
@@ -110,29 +110,29 @@
 HalpClockInterruptHandler(IN PKTRAP_FRAME TrapFrame)
 {
     KIRQL Irql;
-    
+
     /* Enter trap */
     KiEnterInterruptTrap(TrapFrame);
-    
+
     /* Start the interrupt */
     if (HalBeginSystemInterrupt(CLOCK2_LEVEL, PRIMARY_VECTOR_BASE, &Irql))
     {
         /* Update the performance counter */
         HalpPerfCounter.QuadPart += HalpCurrentRollOver;
         HalpPerfCounterCutoff = KiEnableTimerWatchdog;
-        
+
         /* Check if someone changed the time rate */
         if (HalpClockSetMSRate)
         {
             /* Not yet supported */
             UNIMPLEMENTED;
-            while (TRUE);
+            ASSERT(FALSE);
         }
-        
+
         /* Update the system time -- the kernel will exit this trap  */
         KeUpdateSystemTime(TrapFrame, HalpCurrentTimeIncrement, Irql);
     }
-    
+
     /* Spurious, just end the interrupt */
     KiEoiHelper(TrapFrame);
 }
@@ -142,18 +142,18 @@
 HalpProfileInterruptHandler(IN PKTRAP_FRAME TrapFrame)
 {
     KIRQL Irql;
-    
+
     /* Enter trap */
     KiEnterInterruptTrap(TrapFrame);
-    
+
     /* Start the interrupt */
     if (HalBeginSystemInterrupt(PROFILE_LEVEL, PRIMARY_VECTOR_BASE + 8, &Irql))
     {
         /* Profiling isn't yet enabled */
         UNIMPLEMENTED;
-        while (TRUE);
+        ASSERT(FALSE);
     }
-    
+
     /* Spurious, just end the interrupt */
     KiEoiHelper(TrapFrame);
 }




More information about the Ros-diffs mailing list