[ros-diffs] [mjmartin] 44992: [include/usb200.h] - Fix two unions, make text after last #endif a comment as it should be, and add newline at end of file.
mjmartin at svn.reactos.org
mjmartin at svn.reactos.org
Fri Jan 8 10:00:53 CET 2010
- Previous message: [ros-diffs] [ros-arm-bringup] 44991: - Document and define Timer and System Control Ports (0x43, 0x61) as defined in ISA System Architecture 3rd Edition and The Undocumented PC. - Document PIT access modes, channels and operating modes. - Rewrite HalHandleNMI to use the System Control Port definitions instead of magic values that were never explained. - Rewrite HalMakeBeep not to program the PIT with magic hexadecimal values that were not explained anywhere and seem dubious. - Fix the PIT frequency to match its correct value of ~1.19318MHz which is what every x86 book states and what Linux and all other operating systems use. This is equivalent to one third of the NTSC color burst (subcarrier frequency) used on CGA computers for video output. Previously, the HAL used 1.193167MHz, which is only used by NT and isn't documented anywhere, and in fact appears to be a typo in the NT sources (a less accurate way of dividing the NTSC color burst gives 1.19318167MHz). Somehow, the ReactOS developer of this function must have made the same "typo", by complete coincidence, of course. - Rewrite part of HalpInitializeClock to use the new definitions. This function was at least somewhat documenting the magic values.
- Next message: [ros-diffs] [mjmartin] 44993: [usb/usbehci] - Initial implementation of usbehci, aka USB 2.0. - Implement AddDevice, StartDevice, InterruptService and DPC Routines. - Implement basic IRP queuing and handling. - Implement starting, stopping of EHCI controller and querying port capabilities. - Implement PNP for Query Relations, Query ID, Query BusInfo. - Implement finding the active ports when USB devices are attached and releasing control to companion controller if devices is not a high speed devices. - Implement reporting devices connects to upper Pdo (hub) driver. - Hub driver attaches successfully and sends URBs to query descriptors from USB devices on Windows. - Currently not build enabled as it will cause problems with current UsbDriver in trunk. - Code heavily based on current PCI drivers and UsbDriver from trunk.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: mjmartin
Date: Fri Jan 8 10:00:53 2010
New Revision: 44992
URL: http://svn.reactos.org/svn/reactos?rev=44992&view=rev
Log:
[include/usb200.h]
- Fix two unions, make text after last #endif a comment as it should be, and add newline at end of file.
Modified:
trunk/reactos/include/ddk/usb200.h
Modified: trunk/reactos/include/ddk/usb200.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/usb200.h?rev=44992&r1=44991&r2=44992&view=diff
==============================================================================
--- trunk/reactos/include/ddk/usb200.h [iso-8859-1] (original)
+++ trunk/reactos/include/ddk/usb200.h [iso-8859-1] Fri Jan 8 10:00:53 2010
@@ -27,7 +27,7 @@
UCHAR Reserved:3;
UCHAR Type:2;
UCHAR Dir:1;
- };
+ } _BM;
UCHAR B;
} BM_REQUEST_TYPE, *PBM_REQUEST_TYPE;
@@ -80,7 +80,7 @@
USHORT MaxPacket:11;
USHORT HSmux:2;
USHORT Reserved:3;
- };
+ } _MP;
USHORT us;
} USB_HIGH_SPEED_MAXPACKET, *PUSB_HIGH_SPEED_MAXPACKET;
@@ -109,4 +109,4 @@
#include <poppack.h>
-#endif __USB200_H__
+#endif //__USB200_H__
- Previous message: [ros-diffs] [ros-arm-bringup] 44991: - Document and define Timer and System Control Ports (0x43, 0x61) as defined in ISA System Architecture 3rd Edition and The Undocumented PC. - Document PIT access modes, channels and operating modes. - Rewrite HalHandleNMI to use the System Control Port definitions instead of magic values that were never explained. - Rewrite HalMakeBeep not to program the PIT with magic hexadecimal values that were not explained anywhere and seem dubious. - Fix the PIT frequency to match its correct value of ~1.19318MHz which is what every x86 book states and what Linux and all other operating systems use. This is equivalent to one third of the NTSC color burst (subcarrier frequency) used on CGA computers for video output. Previously, the HAL used 1.193167MHz, which is only used by NT and isn't documented anywhere, and in fact appears to be a typo in the NT sources (a less accurate way of dividing the NTSC color burst gives 1.19318167MHz). Somehow, the ReactOS developer of this function must have made the same "typo", by complete coincidence, of course. - Rewrite part of HalpInitializeClock to use the new definitions. This function was at least somewhat documenting the magic values.
- Next message: [ros-diffs] [mjmartin] 44993: [usb/usbehci] - Initial implementation of usbehci, aka USB 2.0. - Implement AddDevice, StartDevice, InterruptService and DPC Routines. - Implement basic IRP queuing and handling. - Implement starting, stopping of EHCI controller and querying port capabilities. - Implement PNP for Query Relations, Query ID, Query BusInfo. - Implement finding the active ports when USB devices are attached and releasing control to companion controller if devices is not a high speed devices. - Implement reporting devices connects to upper Pdo (hub) driver. - Hub driver attaches successfully and sends URBs to query descriptors from USB devices on Windows. - Currently not build enabled as it will cause problems with current UsbDriver in trunk. - Code heavily based on current PCI drivers and UsbDriver from trunk.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list