June 2010 Archives by thread
Starting: Mon May 31 22:34:17 UTC 2010
Ending: Wed Jun 30 19:36:38 UTC 2010
Messages: 408
- [ros-diffs] [ekohl] 47505: [SMSS] - Create a new default paging file if no paging files exist. - Set the calculated paging file sizes in the registry. - Remove predefined paging file name from the hivesys*.inf files. Fixes bug #4048.
ekohl at svn.reactos.org
- [ros-diffs] [cgutman] 47506: [NPFS] - Acquire the cancel spin lock before calling IoSetCancelRoutine - Remove the old cancellation code - Don't use the CCB stored in the IRP because it could be invalid depending on the state of the IRP - Simplify thread termination - Fixes random crash during rpcrt4:ndr_marshall test
cgutman at svn.reactos.org
- [ros-diffs] [dreimer] 47507: Add the non yet working FF 3.6 and AbiWord 2.8.5 to rapps to simplify testing. Sync the rest
dreimer at svn.reactos.org
- [ros-diffs] [janderwald] 47508: [NPFS] - Return buffer size if the buffer is too small
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47509: [NPFS] - Add more buffer checks - Clear DO_DEVICE_INITIALIZING flag
janderwald at svn.reactos.org
- [ros-diffs] [arty] 47510: Add invariant checks and fix a bug: Copy+Paste error misusing OldFlink
arty at svn.reactos.org
- [ros-diffs] [gadamopoulos] 47511: [rbuild] msvc backend: - Start implementing real support for vcxproj files - Fix generating sln files - Move msvc rules in a separate folder - Various fixes
gadamopoulos at svn.reactos.org
- [ros-diffs] [janderwald] 47512: [NPFS] - Check if MmGetSystemAddressForMdlSafe failed
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47513: [NPFS] - Fix 2 memory leaks when creating a pipe fails - Fix minor style issue
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47514: [NTOS] - Fix assertion hit during install - Fix identation - Remove superflous spaces
janderwald at svn.reactos.org
- [ros-diffs] [gschneider] 47515: [FONTVIEW] Select the oldest font back into the DC, leftover from bug #5182
gschneider at svn.reactos.org
- [ros-diffs] [cgutman] 47516: [NTOSKRNL] - Revert the hack in r47514 - The ASSERT is there to make sure the PFN lock is held - Fix the issue properly by holding the PFN lock while initializing
cgutman at svn.reactos.org
- [ros-diffs] [fireball] 47517: [HAL] - Fix a typo.
fireball at svn.reactos.org
- [ros-diffs] [dreimer] 47518: Polish Translation Updates by Maciej Bialas.
dreimer at svn.reactos.org
- [ros-diffs] [sginsberg] 47519: [HAL] Fix compiler preprocessor checks for the IRQL masks so other compilers than GCC get proper entries too. [HAL] Define the HalpHardwareInterrupt macro for MSVC too. [HAL] Replace IRQL_DEBUG with DBG so we always check for incorrect IRQL on debug. I believe incorrect IRQL raise/lower is a common and serious enough error to always be checked for on debug builds without defining some special debug option.
sginsberg at svn.reactos.org
- [ros-diffs] [ilardig] 47520: Several Italian translation updates by Paolo Devoti. See issue #5438 for more details.
ilardig at svn.reactos.org
- [ros-diffs] [ilardig] 47521: [netshell] - Improve current network connection status icons.
ilardig at svn.reactos.org
- [ros-diffs] [gadamopoulos] 47522: [win32k[win32k] -Allow menus to be shown over the taskbar See issue #5415 for more details.
gadamopoulos at svn.reactos.org
- [ros-diffs] [gadamopoulos] 47523: [win32k] - Fix detection of file type while generating vcxproj files
gadamopoulos at svn.reactos.org
- [ros-diffs] [ilardig] 47524: [usetup] - The last error messages were swapped in some languages, spotted by Paolo Devoti. - Added the minimum required disk space also in the debug print. See issue #5440 for more details.
ilardig at svn.reactos.org
- [ros-diffs] [ekohl] 47525: [SYSDM] - Fix a bug in the creation of the 'PagingFiles' registry value. - Set paging file sizes only if both user defined sizes are valid numerical values and display a warning otherwise. - Translators: Please translate the message strings!
ekohl at svn.reactos.org
- [ros-diffs] [ilardig] 47526: [SYSDM] - Update Italian and Spanish translations.
ilardig at svn.reactos.org
- [ros-diffs] [mjmartin] 47527: [crt] - mbstowcs: Fix incorrect size passed as the second parameter for call to RtlMultiByteToUnicodeN. Fixes loading assemblies when manifest is in a manifest file due to parsing failure.
mjmartin at svn.reactos.org
- [ros-diffs] [tkreuzer] 47528: reduce diff to trunk
tkreuzer at svn.reactos.org
- [ros-diffs] [mjmartin] 47529: [rtl] - len returned from mbstowcs is the required size of the destination string, so only allocate the needed size. - When doing the actual conversion pass in the size of the ansi string not the needed size of destination. - These changes were missed in 47527.
mjmartin at svn.reactos.org
- [ros-diffs] [cgutman] 47530: [FREELDR] - Verify that Int 13 extensions are supported before trying to use them
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47531: [FREELDR] - Remove an overzealous API check and the work-around for it
cgutman at svn.reactos.org
- [ros-diffs] [tkreuzer] 47532: reduce diff to trunk
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47533: Merge 46523 from amd64 branch: - Fix assert macro - Add crt="MSVC" to a number of modules to resolve _assert
tkreuzer at svn.reactos.org
- [ros-diffs] [ekohl] 47534: [SYSDM] - Check the custom paging file sizes for being within useful limits and display warnings if these limit were exceeded. - Translators: Please translate the message strings!
ekohl at svn.reactos.org
- [ros-diffs] [ekohl] 47535: [NTOSKRNL] NtDuplicateToken: If the called does not provide any desired access rights the duplicate token will inherit the granted rights of the original token.
ekohl at svn.reactos.org
- [ros-diffs] [tkreuzer] 47536: [RBUILD] Revert 46791, we don't need it anymore since we have the new RosBE
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47537: [NTOSKNRL] Add AVL tree code. Incomplete and unused yet.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47538: merge 46805 from amd64 branch: [RBUILD] Fix some parameters (starting with --, not with -)
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47539: [RBUILD] - append stdcall decoration only for i386 target
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47540: [ACPICA] - Hack acwin64.h, don't assume msvc for win64
tkreuzer at svn.reactos.org
- [ros-diffs] [ilardig] 47541: [SYSDM] - Update Italian and Spanish translations. - Add untranslated strings to the rest of the languages.
ilardig at svn.reactos.org
- [ros-diffs] [tkreuzer] 47542: [rbuild] - cleanup obsolete rbuild flags for amd64 - undefine WIN32 for amd64, only _WIN32 should be defined
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47543: [DDK] Make RtlLargeIntegerDivide FORCEINLINE instead of __inline to avoid multiple definitions
tkreuzer at svn.reactos.org
- [ros-diffs] [gadamopoulos] 47544: [user32] - Remove a reactos only export (PrivateCsrssInitialized) - Don't call NtUserGetClassLong - Move implementation of AnyPopup to user mode - Fix a small bug in GetParent and in IsChild [csrss] - Don't call PrivateCsrssInitialized [win32k] - Call CsrInit in NtUserInitialize so we can remove PrivateCsrssInitialized - Romove a reactos only syscall (NtUserGetClassLong) - Remove UserGetClassLongPtr, UserGetWindow, UserGetWindowLong, IntGetOwner. Instead access objects directly - In WINDOW_OBJECT store pointer to the ownder window instead of a handle
gadamopoulos at svn.reactos.org
- [ros-diffs] [tkreuzer] 47545: [BROWSEUI] merge r44391 from amd64 branch fix 64bit build
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47546: [PSDK] add LVSIL_GROUPHEADER definition to commctrl.h
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47547: [COMCTRL32] Sync listview.c with wine 1.2 rc2
tkreuzer at svn.reactos.org
- [ros-diffs] [gschneider] 47548: [DESK] - Rearrange screensaver wait codes around the MsgWaitForMultipleObjects function - Fixes screensaver configuration windows blocking the control panel - Refs: http://blogs.msdn.com/b/oldnewthing/archive/2005/02/17/375307.aspx and http://codereflect.com/2008/09/19/when-and-how-should-we-use-msgwaitformultipleobjects/ See issue #4213 for more details.
gschneider at svn.reactos.org
- [ros-diffs] [tkreuzer] 47549: [GDI32API] add IsHandleValid and use it SelectObject test
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47550: [W32KNAPI] Add few more tests for NtGdiCreateBitmap
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47551: [ROSTESTS] Fix 64 bit build of some modules (Samuel Serapion, modified by me)
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47552: [ReactOS-amd64.rbuild] The old explorer won't compile for amd64 without massive hacking, so remove it from the build.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47553: [DDK} Add a number of PCI related types to ntddk.h
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47554: Revert r47553 because testbot doesn't like it
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47555: [DDK] 2nd try, this time adding half of the structures.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47556: [DDK] In an incredibly daring move, add even more types to ntddk.h
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47557: [HAL] Include the correct headers for amd64 vs i386
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47558: [DDK] try to work around the testbot brokenness with an #if 0"
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47559: [DDK] Merge the rest of the old header-branch version of ntddk.h, but with a large number of additional types #if 0'ed out
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47560: try to fix build
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47561: revert 47559 and 47560 (once again... sigh)
tkreuzer at svn.reactos.org
- [ros-diffs] [jmorlan] 47562: [KERNEL32], [WIN32CSR] - Make Get/SetConsoleTitle more compatible with windows; in particular, transfer title via capture buffer to allow for longer titles. - Tighten up capture buffer validation in win32csr.
jmorlan at svn.reactos.org
- [ros-diffs] [tkreuzer] 47563: [HAL] - Move memory functions from halinit.c to new memory.c - HalpAllocPhysicalMemory: MemoryFirmwareTemporary -> LoaderFirmwareTemporary (same value, different enum)
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47564: [NTOSKRNL] Implement KeRegisterInterruptHandler and KeQueryInterruptHandler for amd64
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47565: [HAL] - Move all amd64 specific files to one amd64 folder - Compile x86 specific timer code only on x86 - Use KeRegisterInterruptHandler instead of manual idt manipulation - add missing stubs for amd64
tkreuzer at svn.reactos.org
- [ros-diffs] [gadamopoulos] 47566: [win32k] - CreateWindow: initialize window position after sending WM_GETMINMAXINFO message
gadamopoulos at svn.reactos.org
- [ros-diffs] [tkreuzer] 47567: [KS] - KSSTREAM_POINTER_OFFSET doesn't have an Alignment member on 64 bit systems. Comment the use out in these cases. It should probably be removed completely, as it's only an alignment / dummy value, but I leave this to the expert in this field. - ULONG -> ULONG_PTR for pointer casts
tkreuzer at svn.reactos.org
- [ros-diffs] [jmorlan] 47568: [WIN32CSR] Consistently store console input events internally as unicode.
jmorlan at svn.reactos.org
- [ros-diffs] [tkreuzer] 47569: [HAL] Delete empty folder
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47570: [NTOS]: Allocate non-paged pool pages with MiRemoveAnyPage instead of MmAllocPage.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47571: Testers: Please test this build. [NTOS]: Implement a MI_MAKE_HARDWARE_PTE macro for the generation of valid kernel PTEs instead of always taking the ValidKernelPte and changing its flags. This macro will take into account the protection mask (up until now ignored) and use the array previously implemented to determine the correct hardware PTE settings. Assertions are also added to validate correct usage of the macro, and later revisions will fill out NT-specific fields to help deal with transition PTEs, page faults, etc. [NTOS]: Make the stack code the first user of this macro, for the stack PTEs. Good testing base as we create kernel stacks very often. [NTOS]: The NT MM ABI specifies that in between the allocation of a new PTE and its initialization as a valid PFN, the PTE entry should be an invalid PTE, and should only be marked valid after the PFN has been initialized. For stack PTEs, do this -- first allocating the page, making it invalid, then initializing the PFN, and then writing the valid page.
sir_richard at svn.reactos.org
- [ros-diffs] [jmorlan] 47572: [WIN32CSR] Console input simplification: - Put code for processing events for line input in one place, instead of duplicating it everywhere - Remove "Fake" and "NotChar" fields from ConsoleInput struct. ConioProcessKey didn't actually add Fake events; they were used for the \n when converting \r to \r\n, but this is better done by the line input code. - Build an input line completely on the server side; this will make it practical to add history and more sophisticated editing later
jmorlan at svn.reactos.org
- [ros-diffs] [tkreuzer] 47573: [MMEBUDDY] Make mmebuddy more 64bit compliant. Based on r40127 by Samuel Serapion with some modifications by me.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47574: [DDK] Fix definition of USE_DMA_MACROS
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47575: [NTOS]: Build paged pool demand-zero PTE with MI_MAKE_SOFTWARE_PTE macro. [NTOS]: Handle paged pool demand-zero fault fulfillment with MI_MAKE_HARDWARE_PTE macro. [NTOS]: Use MiRemoveAnyPage instead of MmAllocPage, in paged pool demand-zero fault fulfillment. These changes affect code paths that are not currently in-use.
sir_richard at svn.reactos.org
- [ros-diffs] [cgutman] 47576: [FREELOADER] - Remove duplicated code - Add back the Mac hack but use 0x8A for the lowest CD-ROM drive number instead of 0x90
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47577: [FREELOADER] - Use the old method for identifying the drive type (based on partition number) which actually works for floppies now because I changed the DrivePartition value returned (floppy = 0, cdrom = 0xFF) in a previous commit - Fixes bug 5233
cgutman at svn.reactos.org
- [ros-diffs] [tkreuzer] 47578: [winnt.h] Fix definition of KNONVOLATILE_CONTEXT_POINTERS for amd64
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47579: [NTOS]: When expanding paged pool, use MiRemoveAnyPage, not MmAllocPage. [NTOS]: When expanding paged pool, initialize the PFN entry for the allocated page. Note we might be in arbitrary process space, so the PTE is not necessary valid for the process causing the expansion. [NTOS]: Implement MiInitializePfnForOtherProcess to handle the case above. [NTOS]: Change two static ASSERTs into C_ASSERTs. Might break non-x86 builds for a bit (vs breaking them at boot, which is worse). Paged pool should start working soon.
sir_richard at svn.reactos.org
- [ros-diffs] [jmorlan] 47580: [KERNEL32], [WIN32CSR] - Implement console history (note: not too useful yet without any way to recall it) - Implement APIs GetConsoleCommandHistoryLength, GetConsoleCommandHistory, ExpungeConsoleCommandHistory, SetConsoleNumberOfCommands, GetConsoleHistoryInfo, SetConsoleHistoryInfo. - Remove stub of obsolete function SetConsoleCommandHistoryMode, which no longer exists in Windows.
jmorlan at svn.reactos.org
- [ros-diffs] [jmorlan] 47581: add missing file
jmorlan at svn.reactos.org
- [ros-diffs] [sir_richard] 47582: [NTOS]: Implement MiDeleteSystemPageableVm. [NTOS]: The paged pool free code was behaving incorrectly, assuming that paged pool was "locked down" and never paged out/reused (a valid NT operation mode), while the allocation code was assuming paged pool was a volatile, reusable, pageable resource (normal NT operation mode). The free code now assumes normal operation mode, and actually frees the freed paged pool pages, by using MiDeleteSystemPageableVm. I have a feeling this will make ARM3 paged pool work.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47583: [WIN32K] Implement EngCreateSection, EngMapSection, EngFreeSectionMem, EngAllocSectionMem, EngLoadModuleEx, EngLoadModule, EngLoadModuleForWrite, EngMapModule, EngFreeModule, EngMapFile, EngUnmapFile. Unused & untested.
tkreuzer at svn.reactos.org
- [ros-diffs] [jmorlan] 47584: [WIN32CSR] Implement some basic line editing capability
jmorlan at svn.reactos.org
- [ros-diffs] [fireball] 47585: [VENDOR/WINE] - Import Wine-1.2-rc2 gdi32, user32, winex11.drv, wineserver.
fireball at svn.reactos.org
- [ros-diffs] [ekohl] 47586: [NTOSKRNL] NtDuplicateToken: Fail, if a primary token is to be created from an impersonation token and and the impersonation level of the impersonation token is below SecurityImpersonation.
ekohl at svn.reactos.org
- [ros-diffs] [sir_richard] 47587: [NTOS]: In MiDeleteSystemPageableVm, should also handle the case where the PTE is demand-zero. This can happen if the caller allocated, say, 12KB (3 pages) of paged pool, only touched 4KB (1 page), and then frees the allocation -- the other 2 pages will still be demand-zero at this point.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47588: [NTOS]: In MiInitializePfnForOtherProcess, should increment the sharecount of the page table PFN entry, not the PFN entry of the PTE itself. Spotted by Stefan100.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47589: [NTOS]: Don't assume that ANY fault in the system address range, not associated to a memory area, might be ARM3. Instead, since this hack only exists for early boot page pool support, make only treat this as an ARM3 fault when it happens in the paged pool area or higher. Leads to more direct Mm crashes when invalid page access happens, instead of infinite "PAGE FAULT ON PAGE TABLES".
sir_richard at svn.reactos.org
- [ros-diffs] [fireball] 47590: - Sync up to Wine-1.2-rc2.
fireball at svn.reactos.org
- [ros-diffs] [tkreuzer] 47591: [WIN32K] - Simplify the logic of the mapping functions a bit, by using either FILEVIEW or ENGSECTION, not both. - Set FILEVIEW::LastWriteTime
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47592: [NTOS]: Define the POOL_HEADER for x64. [NTOS]: Define POOL_BLOCK_SIZE definition to set the minimum pool block size. In NT, this is equal to a LIST_ENTRY structure, because the Pool Allocator must be able to store a LIST_ENTRY into a freed pool block. This also determines the alignment of pool allocations. So 8 on x86, 16 on x64. [NTOS]: Don't depend on LIST_ENTRY, but use POOL_BLOCK_SIZE instead (on IA64, if we ever want to support this, the pool block size is different from a LIST_ENTRY/POOL_HEADER). [NTOS]: The following ASSERTs must hold: the POOL_HEADER must be as big as the the smallest pool block (POOL_BLOCK_SIZE), which must be at least as big as a LIST_ENTRY structure. 8 == 8 == 8 on x86, 16 == 16 == 16 on x64.
sir_richard at svn.reactos.org
- [ros-diffs] [cgutman] 47593: [NTOSKRNL] - Print the base address of the process that we killed to make debugging much easier
cgutman at svn.reactos.org
- [ros-diffs] [sir_richard] 47594: [NTOS]: Use logical math operations on the various block<->entry<->free_list_head operations in the pool code, instead of works-by-chance-and-assumption pointer math operations. This will now allow pool implementations where the pool header is not the size of a pool block (and the size of a LIST_ENTRY, by definition, although, even that, could change, if we choose to implement a cache-aligned overhead).
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47595: [NTOS]: Defensive programming on the pool macros.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47596: [NTOS]: Add some paranoid-invariant list access checks to the pool code. They serve a dual purpose: catch pool corruption by broken drivers/kernel code, as well as catch malicious modification of the pool links as part of a kernel-mode exploit. [NTOS]: Not yet used, thanks to Arthur for the idea. See comment for more information.
sir_richard at svn.reactos.org
- [ros-diffs] [jmorlan] 47597: [WIN32CSR] - Implement basic support for history in line editing - Reorganize code to reflect that line input is more coupled to history than it is to character input
jmorlan at svn.reactos.org
- [ros-diffs] [sir_richard] 47598: [NTOS]: Fix Exp*PoolList macros. Also make then non-inlined, so we can see who called them in a stack trace. [NTOS]: Enable them. This boots on my system -- if it doesn't boot on yours, someone is corrupting your nonpaged pool. Reverting this patch is NOT the solution to your woes.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47599: [NTOS]: Kill debug spew.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47600: [NTOS]: Fix up POOL_PREV_BLOCK based on suggestion by hpoussin. [NTOS]: Fix up NTAPI location in function definition. [NTOS]: Implement even more stringent header checks: ExpCheckPoolHeader and ExpCheckPoolBlocks. Normally we would only want this on a DBG build, but I am enabling them for now until I can fix paged pool. If your machine crashes, reverting this commit is NOT the solution (boots for me). [NTOS]: Add a AllowPagedPool BOOLEAN that will allow us to selectively enable when the ARM3 pool can be used, playing around with the situation that causes the corruption, and perhaps making it easier to find/fix.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47601: [NTOS]: Even after allowing ARM3 paged pool, we should still use the old allocator to free allocations made by the old allocator!
sir_richard at svn.reactos.org
- [ros-diffs] [fireball] 47602: - Copy bitmap even if it can't be selected into the dc (e.g. when it's already selected into another DC) using already existing helper. Fixes mouse cursor icon problem.
fireball at svn.reactos.org
- [ros-diffs] [tkreuzer] 47603: [WIN32K] Make the SURFACE structure a bit more like the half documented windows version.
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47604: [NTOS]: Kill some debug spew.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47605: [NTOS]: Fix for the the bug that broke ARM3 paged pool (and has been corrupting ReactOS paged pool behind the scenes for years): When a KCB (key stuff) is allocated, the key name associated with it receives an NCB (name stuff). In case this name is already used, a cache exists, and an existing NCB is grabbed, and its reference count is increased. When the KCB goes away, its NCB loses a reference. When all references are gone, the NCB is destroyed. Simple enough. It turns out that what was currently happening is that an NCB would get dereferenced to 0, deleted, but still remained attached to a valid KCB (shouldn't happen). When that KCB went away, the NCB's reference count was dropped to... -1, and then -2, -3, -4, etc. Remember this is a FREED NCB. In other words, freed pool, that might now belong to someone else, was getting "-1" operations on it. So any value stored in that freed pool would get decremented by one. In ARM3 paged pool, because the allocator keeps a linked list, what would happen is that the FLINK pointer would be 0xE0F01234 instead of 0xE1A01234. What happened is that "0xE1A0" was treated as the reference count of the freed NCB, and it kept getting dereferenced down to 0xE0F0. Proving this was easy, by adding an ASSERT(Ncb->RefCount >= 1) to the routine that dereferences NCBs. Obviously, we should not try to dereference an NCB that has a reference count of 0, because that NCB is now gone. Adding this ASSERT immediately caught the error, regardless of which pool implementation was being used, so this was a problem in ReactOS today, right now. My first thought was that we were taking references to NCBs without incrementing the reference count. The NCB gets referenced in two places: when it gets created, and everytime a cached NCB is re-used for a new KCB (all this in CmpGetNameControlBlock). After adding some tracing code, I discovered that CmpGetNameControlBlock would sometimes return an NCB that was cached, but without referencing it. I did not understand why, since the code says "if (Found) Ncb->RefCount++". Further analysis showed that what would happen, on this particular instance, is that NCB "Foo" was being Found, but NCB "Bar" was returned instead. Therefore, causing some serious issues: First, NCB Foo was receiving too many references. Secondly, NCB Bar was not being referenced. Worse though, it turns out this would happen when "Foo" was the CORRECT NCB, and "Bar" was an INCORRECT NCB. What do we mean by correct and incorrect? Well, because NCBs are hashed, it's possible for two NCB hashes to be VERY SIMILAR, but only ONE OF THOSE NCBs will be the right one -- for example, HKLM\Software\Hello vs HKLM\Software\Hell. In our case, when a KCB for "Hello" was searching for the "Hello" NCB, the "Hello NCB would get a reference, but the "Hell" NCB would be returned. In other words, whenever a HASH COLLISION happened, the incorrect NCB was returned, probably messing up registry code in the process. Subsequently, when the KCB was dereferneced, it was attached to this incorrect, under-referenced NCB. Since in ANY hash collision with "Hell", in our example, the "Hell" NCB would come first, subsequent searches for "Hellmaster", "Hellboy", "Hello World" would all still return "Hell". Eventually when all these KCBs would go away, the "Hell" NCB would reach even -18 references. The simple solution? When the CORRECT NCB is found, STOP SEARCHING! By adding a simple "break" statement. Otherwise, even after the correct NCB is found, further, incorrect, collided NCBs are found, and eventually the last one ("Hell", in our example) got returned, and under-referenced, while "Hellmaster" and "Hellboy" were not returned, but LEAKED REFERENCES. There you have it folks, MEMORY CORRUPTION (USE-AFTER-FREE), INCORRECT REGISTRY NAME PARSHING, REFERENCE LEAKS and REFERENCE UNDERRUNS, all due to ONE missing "break; ". -r
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47606: [WIN32K] - Allocate bitmaps as kernel sections, instead of from paged pool, like it's done in windows. - Fix SURFACE_Cleanup. It was only freeing the memory for API_BITMAPs. If memory was allocated by a driver it never got freed. - Add BMF_RLE_HACK flag to free decompressed RLE bits - Support FL_ZERO_MEMORY in EngAllocSectionMem - Set SURFOBJ::iType when creating a surface
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47607: [NTOS]: Silence more debug spew.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47608: [NTOS]: Clean up /mm a bit, move sysldr.c into ARM3.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47609: [WIN32K] Do not free the memory for the bitmap bits, when you have not allocated them. Fixes bugcheck with VBox driver.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47610: [WIN32K] Add another failure check to EngAllocSectionMem
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47611: [WIN32K] Once again: Do not free the memory for the bitmap bits, when you have not allocated them.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47612: [WIN32K] - Move RLE specific code to it's own file (rlecomp.c) - Relace BitsPerFormat function with an array of UCHARs - Rewrite surface creation. Surfaces are now allocated from one central function SURFACE_AllocSurface, which sets the size, iType, iUniq, the handle and the default palette. - Implement SURFACE_vSetDefaultPalette, which sets the default RGB palette, based on bit depth. - Implement SURFACE_bSetBitmapBits, wich sets cjBits, pvBits, pvScan0 and lDelta and allocates memory if neccessary. - Use these functions for EngCreateBitmap, EngCreateDeviceBitmap, EngCreateDeviceSurface and IntCreateBitmap
tkreuzer at svn.reactos.org
- [ros-diffs] [mjmartin] 47613: [rtl] - Fix a overlooked change needed due to mbstowcs fix. Use the number of WCHARs vice number of bytes to calculate end of xmlbuf.
mjmartin at svn.reactos.org
- [ros-diffs] [tkreuzer] 47614: [NTOSKNRL] Add the possibility to break on all first chance exceptions, by passing /FIRSTCHANCE on the command line. Enable it temporary to get some more information from the sysreg crash.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47615: Add /KDSERIAL to the command line, to make sysreg able to bt in first stage.
tkreuzer at svn.reactos.org
- [ros-diffs] [cwittich] 47616: [RosDbg] convert to VS 2010
cwittich at svn.reactos.org
- [ros-diffs] [cwittich] 47617: [RosDbg] upgrade Windows installer project to WiX 3.5
cwittich at svn.reactos.org
- [ros-diffs] [tkreuzer] 47618: [WIN32K] Add Windows compatible alignment code.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47619: [WIN32K] Disable the additional alignment code for now, it breaks selections (text / icons)
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47620: [NTOS]: Fix a loop off-by-one when saving the page table index in contigious memory allocation PFNs. Spotted by Stefan100.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47621: [NTOS]: Implement MiRemoveZeroPage and MiZeroPhysicalPage. Not yet used.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47622: [NTOS]: Don't use MmAllocPage for the first paged pool PDE, instead, use MiRemoveZeroPage. [NTOS]: Use MiInitializePfnForOtherProcess to setup the first paged pool PDE.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47623: [NTOS]: A PFN entry is not necessarily physical only if it is higher than MmHighestPhysicalPage. It can also be physical if it lies in a memory hole within the min-max physical page range. We can detect this by using our PFN Bitmap. So replace all "Is this an I/O mapping?" checks with a check on whether or not the PFN Database entry is NULL (which will check for us both of these statements). This ought to be a macro...
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47624: [NTOS]: Another one bites the dust, another one bites the dust. And another one gone and another one gone. Another one bites the dust, yeah. Out of the doorway the bullets rip, Repeating to the sound of the beat.
sir_richard at svn.reactos.org
- [ros-diffs] [sginsberg] 47625: - Fix a comment and remove a superfluous extern.
sginsberg at svn.reactos.org
- [ros-diffs] [sir_richard] 47626: [COMPBATT]: Remove useless function.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47627: [NTOS]: Enable usage of ARM3 paged pool, up until Mm Phase 2. [NTOS]: Re-arrange some of the init code, now that we have access to ARM3 paged pool early-on. Move more code to ARM3::INIT in its right place. [NTOS]: Enable using the ARM3 PFN Database, getting rid of the old ReactOS PFN database. Should reduce physical memory usage now that we don't have two copies anymore. [NTOS]: Fix the ARM3 PFN Datbase initialization code. [NTOS]: Get rid of MiInitializePageList, use MiGetPfnEntryOffset instead of hard-coded pointer math in freelist.c. This is the last big low-level Mm/ARM3 patch for a long, long time.
sir_richard at svn.reactos.org
- [ros-diffs] [spetreolle] 47628: Fix RtlIpv4StringToAddressW prototype and its caller in ws2_32. Fixes crash in GetAddrInfoW on xp sp3.
spetreolle at svn.reactos.org
- [ros-diffs] [spetreolle] 47629: Forgotten in previous commit.
spetreolle at svn.reactos.org
- [ros-diffs] [cgutman] 47630: [NDIS] - Implement miniport timer queuing - Add some BUGCODE_ID_DRIVER bug check cases for missing interrupt deregistration, missing timer cancellation, and invalid IRQL when calling NdisMAllocateSharedMemory
cgutman at svn.reactos.org
- [ros-diffs] [gschneider] 47631: [WIN32K] assert -> ASSERT
gschneider at svn.reactos.org
- [ros-diffs] [gschneider] 47632: [WIN32K] Free allocations with the tag that was used to allocate them
gschneider at svn.reactos.org
- [ros-diffs] [sginsberg] 47633: [NTOS] Inline writing to PTEs through MI_WRITE_VALID/INVALID_PTE.
sginsberg at svn.reactos.org
- [ros-diffs] [gschneider] 47634: [WIN32K] Use TAG_GDIICM tag for ICM allocations
gschneider at svn.reactos.org
- [ros-diffs] [gschneider] 47635: [WIN32K] - Use TAG_PALETTE for palette entries - Remove mapping codes, the functions from pre r9000 don't even exist anymore
gschneider at svn.reactos.org
- [ros-diffs] [cgutman] 47636: [NDIS] - Only dequeue the timer in the DPC if the Period is 0 (which means that it's NOT a periodic timer so we only get called once) - Attempt to dequeue the timer before inserting it so we don't end up with multiple copies of the same timer on the timer queue if somebody calls NdisMSet(Periodic)Timer twice
cgutman at svn.reactos.org
- [ros-diffs] [gschneider] 47637: [WIN32K] - Use TAG_KEYBOARD for keyboard layouts - Free TAG_ACCEL and TAG_DRIVER allocations with their tags
gschneider at svn.reactos.org
- [ros-diffs] [tkreuzer] 47638: [WIN32K] Make the bitmap data for the extpens (making extpens bitmaps is a bad idea anyway) 4 bytes long instead of 3, to fulfill alignment requirements.
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47639: Forgot to remove this ASSERT for r47636
cgutman at svn.reactos.org
- [ros-diffs] [fireball] 47640: - Remove my implementation of SWM cursor icons which turned out to be similar to creating an elephant from a fly. Instead use a much simpler, updated and fail-proof implementation by Giannis Adamopoulos. Arwinss is back on track.
fireball at svn.reactos.org
- [ros-diffs] [tkreuzer] 47641: [WIN32K] Rewrite the bitmap API. There were a lot of bugs. NtGdiCreateBitmap allowed a negative height, leading to either topdown or bottomup bitmaps, a behaviour that Windows doesn't have. The function copied the bitmap bits directly from the caller to the bitmap using RtlCopyMemory, ignoring different scanline length and direction (resulting in bitmaps being upside down), not SEH protected. This function (IntSetBitmapBits) is replaced by a better solution UnsafeSetBitmapBits, that takes these things into account. The name is chosen to give a hint that the function can/should be SEH protected. IntSetBitmapBits is still there, as its retarded behaviour is actually required in some places. There were also IntCreateBitmap and IntGdiCreateBitmap, now both being replaced by GreCreateBitmap. The code that set the palette is removed, as it's already done in SURFACE_AllocSurface, here gpalRGB is replaced with gpalBGR, fixing some inverted color issues. The alignment correction in SURFACE_bSetBitmapBits is reapplied, now that the callers are behaving as they are supposed to do.
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47642: [NDIS] - Hold the miniport lock when we work with the timer queue - Use the return value of KeSetTimer(Ex) to determine whether we need to queue the timer in our queue, otherwise we just use the entry that is already there - Add more assertions
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47643: [MSAFD] - Fix many times where we wait for an operation but don't update our status and return if it failed - Fix the overlapped pending case in writing which was completely broken (callers would detect an error but GetLastError would return 0 because we didn't store the error in the lpErrno variable) - Fix many times where we pass a pointer to an event that we close without waiting - Fix a bug in WSPEnumNetworkEvents when we would set WSAEINVAL in the lpErrno variable but not return SOCKET_ERROR so the error got ignored
cgutman at svn.reactos.org
- [ros-diffs] [dreimer] 47644: Add Opera 9 to rapps. Update OOo to 3.2.1 and the last time... fix the FF2 link.
dreimer at svn.reactos.org
- [ros-diffs] [cgutman] 47645: Remove an unintended change
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47646: [MSAFD] - Use a linked list to store the socket information instead of allocating a massive array (1024 elements!) for each process in DllMain to hold all of the pointers - Fix a massive memory leak (free the socket information which we leaked for every socket we allocated) - This improves performance because we don't have to look through an array of stale socket information pointers (which we never actually removed from the socket information array in the old code) and the new code queues the socket information at the head of the list which makes newer sockets faster to access
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47647: I hate making the same mistake twice in one day
cgutman at svn.reactos.org
- [ros-diffs] [sir_richard] 47648: [DHCP/FTP]: Fix building on OS X hosts.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47649: [HAL]: Bus support in the HAL actually creates a further wedge between the different x86 HALs: There are actually two dinstinct implementations. On the ACPI HAL, the system is assumed not to have things like special ISA, MCA, EISA buses, and a PCI driver is used in combination with the ACPI Interface for PCI Bus support. On non-ACPI systems, the legacy "Bus Handler" library is used, and the HAL provides a core set of CMOS, EISA, ISA, MCA and PCI bus handlers, each with their own routines and specific code. Additionally, PCI IRQ Routing and other PCI bus internals are handled directly by the HAL -- on the ACPI HAL, the PCI Bus support is implemented through a "Fake"/static bus handler, just to keep the functions shared. On ReactOS, both the ACPI and non-ACPI HAL were currently using a mix of both HAL bus handling types, mostly implemented the "ACPI way" (with a fake PCI bus handler and such). As a result, none of the Hal*Bus HALDISPATCH routines were implemented, which bus drivers expect to find when they're not on ACPI systems (ReactOS today). eVb's new PCI driver was crashing, for example. Furthermore, legacy systems suffer, because the ACPI HAL Bus routines (that we currently have) expect perfect ACPI-style-compliant systems, not the legacy crap from the early 90ies. This works fine in VMs and new hardware, but old hardware is left behind. This patch basically corrects the first part of the problem, by making the bus handling support separate between ACPI and non-ACPI HALs. For now, the code remains 100% the same in functionality between both. However, I have started adding the first few elements: [HAL]: Implement HalRegisterBusHandler HALDISPATCH routine. [HAL]: On legacy HALs, register the CMOS, ISA, SYSTEM handlers. [HAL]: Add cmosbus.c. Stub all bus-specific bus handler routines in the xxxbus.c files. No real functionality change occurs with this patch, yet.
sir_richard at svn.reactos.org
- [ros-diffs] [cgutman] 47650: [MSAFD] - Validate that we found the corresponding socket information in our socket information list - Fixes a crash in Firefox 2 when it tries to call accept() with a closed socket
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47651: [AFD] - It is legal to send a NULL event object pointer to AFD (this is sent by msafd to cancel an existing event select)
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47652: [MSAFD] - Fix 2 more callers who don't pass a valid lpErrno pointer - Check the return value of WSPSocket - Return WSAEWOULDBLOCK if there are no connections that can be accepted instead of silently returning 0 which is not INVALID_SOCKET so the caller treats it as a valid socket pointer and passes it to other functions which caused wide-spread mayhem since we never checked whether the socket handle the caller passed was valid until my last commit
cgutman at svn.reactos.org
- [ros-diffs] [sir_richard] 47653: [HAL]: Kill debug spew.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47654: [HAL]: Add missing PCI Bus Handler support functions, used on non-ACPI systems (ISA-PCI support and such).
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47655: [HAL]: Detect, initialize, and create bus handlers for, all PCI buses that are found on the machine. [HAL]: Detect PCI-to-PCI Bridges, Extended CardBus Addressing, read Chipset Hacks from Registry, and scan for IRQ lines used by PCI Devices. Scan for PCI-IDE controllers, broken Intel PCI Bridges/Controllers. Scan for OHCI and UHCI USB controllers. Warn the user that if any of these are found, the current HAL does not handle certain types of these devices (these checks are based on the ones the Legacy Windows HAL makes).
sir_richard at svn.reactos.org
- [ros-diffs] [cgutman] 47656: [MSAFD] - Fix a bug in GetSocketStructure that resulted in us missing the last entry of the list - Remove an "optimization" which was supposed to find an unused socket entry (which it almost never did) but now just corrupts the linked list by trashing our NextSocket pointer
cgutman at svn.reactos.org
- [ros-diffs] [dreimer] 47657: Cleanup of the options tool code. By Christoph von Wittich.
dreimer at svn.reactos.org
- [ros-diffs] [mjmartin] 47658: [win32k] - Change the number of windowless timers from 1024 to 32768. - When destroying windowless timers, clear the bit number (IDEvent) in the bitmap so the bit number can be reused. - Only create a windowless timer if there is no windowless timer matching IDEvent. - Fixes case where applications create too many windowless timers and/or run out of windowless timers.
mjmartin at svn.reactos.org
- [ros-diffs] [sir_richard] 47659: [HAL]: Detect IDE controllers. Their interrupts should not be masked.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47660: [NTOS]: Check registry for our CardList, check if the PCI hardware matches any entry in there that specifies it has full/extended address decoding, and write the registry flag for it.
sir_richard at svn.reactos.org
- [ros-diffs] [akhaldi] 47661: Sync trunk.
akhaldi at svn.reactos.org
- [ros-diffs] [sir_richard] 47662: [HAL]: Detect, check for, and warn about, chipset hacks that need to be applied for the machine.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47663: [WIN32K] Introduce GreCreateBitmapEx, which has the extended functionality needed by some callers, GreCreateBitmap calls GreCreateBitmapEx to keep the simple syntax. Use it in DIB_CreateDIBSection to fix build. Also pass the size of the image (still ignored), which is needed for compressed bitmaps (we currently assume that RLEs take as much space as an uncompressed bitmap)
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47664: [HAL]: Implement partly HalpFixupPciSupportedRanges to detect PCI Bridges, and PCI-to-PCI Bridges. The point is we want buses to be cramped down to the addresses supported by the parent bus/bridge. This is NOT currently done, so we warn users of these systems.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47665: [HAL]: Implement HalpGetPciBridgeConfig to detect PCI-to-PCI/CardBus bridges, warn if they are found. [HAL]: Modify the debug messages to be more accurate as to what exactly is unsupported.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47666: [HAL]: Plug in the data from pcidata.c that was committed months ago to display a beautiful enumeration of all PCI devices on the machine. This will allow debug logs not only to contain nearly full hardware information, but also identify the VM the tester/reporter is using (based on the device's subsystem ID). [HAL]: Display all the warning DPRINTs in-line with the PCI enumeration code, resulting in a much easier to read and comprehensive review of the machine.
sir_richard at svn.reactos.org
- [ros-diffs] [akhaldi] 47667: Sync up to trunk head (r47666)
akhaldi at svn.reactos.org
- [ros-diffs] [sir_richard] 47668: [HAL]: I don't like to swear, but F*CK this MiniHAL bullsh*t!
sir_richard at svn.reactos.org
- [ros-diffs] [fireball] 47669: [SYSREG] - Initial commit of a Windows-based sysreg tool by popular demand. Platform is .NET, and the only supported virtual machine is VirtualBox. WIP.
fireball at svn.reactos.org
- [ros-diffs] [sir_richard] 47670: [HAL]: First use of bus handler support: HalGetBusDataByOffset now uses bus handlers. Please report any problems.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47671: [HAL]: Use Bus Handler support for HalSetBusDataByOffset. Please report any problems.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47672: [HAL]: Implement system bus (and ISA) vector/interrupt translation.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47673: [HAL]: Forgot file.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47674: [HALMP]: MP HAL should have HalpDefaultInterruptAffinity too.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47675: [HAL]: Implement PCI Vector/IRQL translation too.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47676: [HAL]: Implement Bus Handler support for HalGetInterruptVector too. The new functionality now includes support for checking against reserved HAL vectors instead of blindling assining IRQLs/Vectors to callers. A warning is printed on the debug log when the old HAL would've returned different values. Please test. If you have issues, the problem is in the DRIVERS, not this code.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47677: [HAL]: Implement system bus address translation.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47678: [HAL]: Implement ISA BUS address translation.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47679: [HAL]: Implement HalTranslateBusAddress using Bus Handler support. The old HAL would just return whatever the caller gave (no translation was done). For example, with the new HAL, this now results in the translation of 0xCF800 in I/O space to fail (not sure which driver requests this), because this is not a valid I/O address on PC/AT systems (highest is 0xFFFF). This change also allows for the PCI driver to override the translation mechanism (which will piggy-back to the system bus translator) with its own. Please test.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47680: [HAL]: Implement HalAdjustResourceList using Bus Handler support. Previous HAL said this was "deprecated" and faked success. Although correct on ACPI HALs, this is a legacy HALs, so Bus Handlers have a chance to do ajdustment.
sir_richard at svn.reactos.org
- [ros-diffs] [akhaldi] 47681: [PSDK] - Fix a "FIXME! HACK!!!"
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47682: [PSDK] - Update/improve some usb related headers' headers.
akhaldi at svn.reactos.org
- [ros-diffs] [sir_richard] 47683: [HAL]: Use Bus Handlers for HalpAssignSlotResources. Warn that current PCI Slot assignment code is frelled. [HAL]: Add PAGED_CODE(); [HAL]: Fix HALACPI build break.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47684: [HAL]: Use Bus Handler support for HalFindBusAddressTranslation. Implement HalpContextToBusHandler to support this. Seems to work fine with bootvid (only user). All the HAL's bus functions now use Bus Handlers on Legacy systems. There are still big issues with PCI cards. eVb: PCI-x should work now. More PCI-related HAL patches may follow later.
sir_richard at svn.reactos.org
- [ros-diffs] [spetreolle] 47685: Enable debug in usetup. This will be reverted in next commit.
spetreolle at svn.reactos.org
- [ros-diffs] [spetreolle] 47686: Revert 47685.
spetreolle at svn.reactos.org
- [ros-diffs] [janderwald] 47687: [WDMAUD_KERNEL] - Extend the mdl hack
janderwald at svn.reactos.org
- [ros-diffs] [tkreuzer] 47688: [ZLIB] Revert r47411. This is a test to see if it fixes the sysreg crash in 1st stage.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47689: [BOOTCD] Add cabman to bootcd. This is for diagnostic purposes.
tkreuzer at svn.reactos.org
- [ros-diffs] [jgardou] 47690: [WIN32K] - remove duplicate prototypes. - Add missing trail to debug print - replace some now superfluous checks on bitmap palette with sanity ASSERTS - begin using BITMAPV5HEADER as a default bitmap format, and introduce conversion to and from everything prior that. Congratulations to BITMAPCOREHEADER, for its backward compatibility personal failure.
jgardou at svn.reactos.org
- [ros-diffs] [tkreuzer] 47691: revert 47688 and 47689
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47692: [WIN32K] NtGdiGetDIBitsInternal: don't use the unsafe usermode pointer after the BITMAPINFO has been converted and protect writing back the result with SEH.
tkreuzer at svn.reactos.org
- [ros-diffs] [jmorlan] 47693: [KERNEL32], [WIN32CSR] - Implement ReadConsoleW's CONSOLE_READCONSOLE_CONTROL structure. - Make pressing Insert during line input work
jmorlan at svn.reactos.org
- [ros-diffs] [gedmurphy] 47694: Add missing info needed for the comctl32 sync
gedmurphy at svn.reactos.org
- [ros-diffs] [gedmurphy] 47695: Part 1 of the comctl32 sync. I'll do it in 2 stages for testing purposes as it's a very large patch. This part includes alpha support for imagelists and tango icons for the common toolbars I'll do the second part later today. It has a propsheet bug and I'm a bit busy at the mo.
gedmurphy at svn.reactos.org
- [ros-diffs] [gedmurphy] 47696: Move UTF8 to the bottom of the file. Thanks to Christoph for the tip
gedmurphy at svn.reactos.org
- [ros-diffs] [tkreuzer] 47697: [PSDK] Merge 47681 and 47682 from header branch - Add missing file headers - Fix defintition of POINTER_64 - by Amine Khaldi
tkreuzer at svn.reactos.org
- [ros-diffs] [akhaldi] 47698: Sync trunk head (r47697).
akhaldi at svn.reactos.org
- [ros-diffs] [spetreolle] 47699: Merge RtlIpv4StringToAddressW fix from network branch.
spetreolle at svn.reactos.org
- [ros-diffs] [tkreuzer] 47700: Sync trunk (r47699)
tkreuzer at svn.reactos.org
- [ros-diffs] [jgardou] 47701: [WIN32K] - More BITMAPV5INFO fun - Probe max size we are asked for when converting to V5 Info [USER32] [WIN32K] - CreateDIBitmap : Move safety handling to win32k, where it belongs. More code cleanness!
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47702: [GDI32] - Header describes the bitmap to be created, not the bits we are passed. - Circumvent gcc weirdness (sigh...)
jgardou at svn.reactos.org
- [ros-diffs] [tkreuzer] 47703: [WIN32K] - Initialize the palettes before creating any bitmaps. - Replace SURFACE_vSetDefaultPalette with an array of default palettes. - Check iFormat in SURFACE_AllocSurface
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47704: [IP] - Handle socket operations that can be completed immediately before terminating the socket to avoid losing data sitting in the receive buffer
cgutman at svn.reactos.org
- [ros-diffs] [gedmurphy] 47705: Merge second part of the comctl32 Wine 1.2 sync. All code currently omits the reactos specific patches. It's been a long time since we synched this lib so it's possible we no longer need them. Time will tell.
gedmurphy at svn.reactos.org
- [ros-diffs] [gedmurphy] 47706: This bug seems to have gone now. Tried to replicate it the devmgmt treeview.
gedmurphy at svn.reactos.org
- [ros-diffs] [fireball] 47707: [SYSREG3] - Print a message if maximum number of retries is exceeded. - Stop executing if ProcessDebugOutput asked so. - Report stopping reason to console.
fireball at svn.reactos.org
- [ros-diffs] [fireball] 47708: - Add "bootcdregtest" in the list of well-known targets.
fireball at svn.reactos.org
- [ros-diffs] [tkreuzer] 47709: [WIN32K] Small bug big effects: Use the correct offset when copying the BITMAPINFO, fixes taskbar icons regression.
tkreuzer at svn.reactos.org
- [ros-diffs] [akhaldi] 47710: - Leftover from the sync.
akhaldi at svn.reactos.org
- [ros-diffs] [janderwald] 47711: [PORTCLS] - Check if resource list has been allocated
janderwald at svn.reactos.org
- [ros-diffs] [gedmurphy] 47712: I don't like this, but add the treeview refresh hack. I don't see this bug on my (windows) build but others are reporting it still happens on the (linux) build machine iso. Maybe it's because linux is akin to the devil? Yes, I like this, let's blame linux!
gedmurphy at svn.reactos.org
- [ros-diffs] [janderwald] 47713: [KS] - Fix memory leak
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47714: [KS] - Perform all allocations / frees in dedicated alloc / free function
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47715: [MMIXER] - Handle failure of device enumeration - Add sanity check
janderwald at svn.reactos.org
- [ros-diffs] [akhaldi] 47716: [DDK] - Replace dciddi.h with the one from mingw-w64 [PSDK] - Get rid of duplicate dciddi.h
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47717: - Update ReactOS-amd64.rbuild
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47718: - Temporarily move those headers from PSDK to DDK (due to svn awesomeness).
akhaldi at svn.reactos.org
- [ros-diffs] [tkreuzer] 47719: [WIN32K] If pbmiSrc->bmiHeader.bV5ClrUsed is 0, calculate the number of colors from the bit depth. Fixes black taskbar icons with vbox driver on 8 bpp
tkreuzer at svn.reactos.org
- [ros-diffs] [akhaldi] 47720: - Add some header guards.
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47721: Sync uo to HEAD (r47720).
akhaldi at svn.reactos.org
- [ros-diffs] [cgutman] 47722: [NTOSKRNL] - Implement IRP_MN_REMOVE_DEVICE handling for PnP root PDOs
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47723: [PCI] - Implement IRP_MN_REMOVE_DEVICE handling for FDOs
cgutman at svn.reactos.org
- [ros-diffs] [tkreuzer] 47724: [WIN32K] - Improve readability in SetBMIColor - Only when BitCount is <= 8, calculate the number of colors in the table - Fixes a crash with VBox driver
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47725: [NTOSKRNL] - Set the resource list pointer to NULL after we free it - Fixes a double-free issue in the resource conflict resolution code
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47726: [ACPI] - Store the interrupt data as the vector and level - Fixes resource conflict issues
cgutman at svn.reactos.org
- [ros-diffs] [akhaldi] 47727: Reintegrate header-work branch. Important changes include continued work on headers and progress on compiling for ARM.
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47728: - Fix localspl and localui build.
akhaldi at svn.reactos.org
- [ros-diffs] [cgutman] 47729: [ACPI] - Create a resource list for the PCI root bus (even though it doesn't use any resources according to ACPI) and fill it with a bus number resource descriptor - Fixes PCI device detection with ACPI enabled
cgutman at svn.reactos.org
- [ros-diffs] [jgardou] 47730: [ROSTESTS] test what happens when a DC is saved and a bitmap is selected into it.
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47731: [WIN32K] - check for the type of the DC to restore to decide whether we should restore the surface Fixes yarotows specific FF3 bug
jgardou at svn.reactos.org
- [ros-diffs] [cgutman] 47732: [DHCPCSVC] - Implement adapter discovery after startup (currently does not work because the iphlpapi code is not implemented)
cgutman at svn.reactos.org
- [ros-diffs] [jgardou] 47733: [WIN32K] - Split NtGdiCreateDIBitmapInternal with its Gre Counterpart - Set bV5ImageSize if it was not already set - Probe bits we're given in NtGdiSetDIBits - SEHize clipboard image data access
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47734: [GDI32] - Protect CreateDIBitmap - Pass correct data size to NtGdiCreateDIBitmap
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47735: [GDI32] - DIB data is not mandatory in CreateDIBitmap [WIN32K] - Simplify GreCreateDIBitmap - Surface data should be 16 bits aligned
jgardou at svn.reactos.org
- [ros-diffs] [akhaldi] 47736: [PSDK] - Deduplicate/improve architecture related definitions.
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47737: [NTDLL_WINETEST] - Re-enable generated.c tests.
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47738: [USER32_WINETEST] - Re-enable generated.c tests. This commit (the previous one too) is a result of the header work reintegration.
akhaldi at svn.reactos.org
- [ros-diffs] [tkreuzer] 47739: reduce diff to trunk
tkreuzer at svn.reactos.org
- [ros-diffs] [pschweitzer] 47740: [NETSHELL] Updated French translation [PAINT] Updated French translation [SHELL32] Updated French translation [SPIDER] Added French translation [SYSSETUP] Updated French translation
pschweitzer at svn.reactos.org
- [ros-diffs] [gschneider] 47741: [WIN32K] Tag more pool allocations
gschneider at svn.reactos.org
- [ros-diffs] [gschneider] 47742: [WIN32K] - Tag even more pool allocations - Remove dead code, adjust comments
gschneider at svn.reactos.org
- [ros-diffs] [gschneider] 47743: [WIN32K] Tag the remaining untagged pool allocations
gschneider at svn.reactos.org
- [ros-diffs] [akhaldi] 47744: [PSDK] - Move the amd64 check before the i386 one, and also check for __i386__
akhaldi at svn.reactos.org
- [ros-diffs] [gschneider] 47745: [WIN32K] Use GDITAG_RBRUSH instead of hardcoding the tag
gschneider at svn.reactos.org
- [ros-diffs] [tkreuzer] 47746: Sync to trunk head (r47736)
tkreuzer at svn.reactos.org
- [ros-diffs] [fireball] 47747: [SYSREG3] - Add hdd creating/emptying during every start of a testing cycle. - Add checkpoints support for 1st and 2nd stages to properly sense the moment when OS shuts down. - Start implementing VM configuration checker/fixer. Right now it only checks and enables/configures a serial port. - Misc logic fixes.
fireball at svn.reactos.org
- [ros-diffs] [jgardou] 47748: [WIN32K] Merge GDIOBJ related changes from yarotows - GDIOBJ_(Share)LockObj : return NULL on NULL input, avoiding debug spew - Set NULL process owner when setting READY_TO_DIE flag of a gdiobj - So now GDIOBJ_ShareUnlockObj can claim ownership before trying to delete the object
jgardou at svn.reactos.org
- [ros-diffs] [ekohl] 47751: [USETUP] - Set the type of the install partition even if it was not created by usetup. This fixes bug #4368.
ekohl at svn.reactos.org
- [ros-diffs] [ilardig] 47752: [SHELL32] - Correctly show accessed and modified times in file properties dialog (they were exchanged).
ilardig at svn.reactos.org
- [ros-diffs] [akhaldi] 47753: [PSDK] - Copy atsmedia.h from our dxsdk to our psdk (replacing the one that's already there) - Add some missing file-headers.
akhaldi at svn.reactos.org
- [ros-diffs] [janderwald] 47754: [WDMAUD_KERNEL] - Perform all allocations / frees in dedicated alloc / free function
janderwald at svn.reactos.org
- [ros-diffs] [akhaldi] 47755: [PSDK] - Add some missing file-headers.
akhaldi at svn.reactos.org
- [ros-diffs] [akhaldi] 47756: [XDK/DDK] - Relax INTERLOCKED_RESULT inclusion guard.
akhaldi at svn.reactos.org
- [ros-diffs] [fireball] 47757: - Merge in changes from Wine-1.1.44 related to supporting the ETO_PDY flag. Unregresses the text rendering in FF 3.5. Thanks to Jan Roeloffzen for help finding this problem and suggesting the right solution.
fireball at svn.reactos.org
- [ros-diffs] [ekohl] 47758: [FORMATTING] Fix indentation. No code changes.
ekohl at svn.reactos.org
- [ros-diffs] [tkreuzer] 47759: [PSDK] Fix a typo (_AMD64 -> _AMD64_)
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47760: [USBD] - Fix the spec file - Fixes usbd build
cgutman at svn.reactos.org
- [ros-diffs] [cgutman] 47761: [FBTUSB] - Import the FreeBT USB generic bluetooth driver (abandoned) - Some slight modifications to make it build - WMI is currently commented out because our WMI headers are lacking (particularly wmistr.h) - Not building by default for now
cgutman at svn.reactos.org
- [ros-diffs] [dreimer] 47762: Bug 5457: updated slovak translations by Mario Kacmar.
dreimer at svn.reactos.org
- [ros-diffs] [janderwald] 47763: [WDMAUD_KERNEL] - Fix possible buffer overflow [MMIXER] - Add sanity checks
janderwald at svn.reactos.org
- [ros-diffs] [ekohl] 47764: [FORMATTING] Fix indentation. No code changes.
ekohl at svn.reactos.org
- [ros-diffs] [ekohl] 47765: [VFATLIB] - Get rid of the hard-coded sector size as large sector (4KB) harddisks are already available. - When a partition is formatted, choose the FAT type according to the partition type. The size of the partition does not matter here as it is up to the caller to set the right partition type according to its size.
ekohl at svn.reactos.org
- [ros-diffs] [ekohl] 47766: [USBD] Replace DWORD by ULONG to make usbd.sys build without errors.
ekohl at svn.reactos.org
- [ros-diffs] [akhaldi] 47767: - Add some missing file-headers.
akhaldi at svn.reactos.org
- [ros-diffs] [tkreuzer] 47768: [PSDK] - ntstatus.h: add STATUS_INVALID_CRUNTIME_PARAMETER - winnt.h: fix 64 bit definition of SLIST_ENTRY
tkreuzer at svn.reactos.org
- [ros-diffs] [spetreolle] 47769: [fbtusb] Fix include casing.
spetreolle at svn.reactos.org
- [ros-diffs] [tkreuzer] 47770: [CRT] - CRT update part 1/x - sync C++ / exception related CRT code with wine - add support for non-underscored symbols - Patch by Samuel Serapion, slightly modified by me
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47771: Add missing file
tkreuzer at svn.reactos.org
- [ros-diffs] [janderwald] 47772: [DRIVERS] - Disable building of SWENUM, MPU401, CMIDriver, SPLITTER, STREAM to reduce build time - Those modules are either unused or don't work yet due to missing functionality
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47773: [SNDBLST_SYS] - Disable building
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47774: [BDAPLGIN, MSDVBNP, MSVIDCTL, BDASUP] - Disable building dvb stack untill ks has the required functionality
janderwald at svn.reactos.org
- [ros-diffs] [akhaldi] 47775: [XDK] - Deduplicate FSRTL_COMMON_FCB_HEADER_LAYOUT in ntifs.h - Move ECP_HEADER from the ntifs template to fsrtltypes.h [DDK] - Update ntifs.h to reflect XDK changes.
akhaldi at svn.reactos.org
- [ros-diffs] [dreimer] 47777: Make using the System Path Variable optional again, because make suffers from a bug with path variables with () in it. This makes RosBE almost unuseable in 64 bit Windows.
dreimer at svn.reactos.org
- [ros-diffs] [dreimer] 47778: Sync winefile to Wine 1.2 RC3
dreimer at svn.reactos.org
- [ros-diffs] [khornicek] 47779: [OPENGL32_WINETEST] Add opengl32 winetest, patch by Jerome Gardou. Not used for now.
khornicek at svn.reactos.org
- [ros-diffs] [khornicek] 47780: [OPENGL32] Fixes for ICD reference counting. By Jerome Gardou See issue #5257 for more details.
khornicek at svn.reactos.org
- [ros-diffs] [ilardig] 47781: [REGEDIT] - Implement hex editing. Patch by Katayama Hirofumi. See issue #5447 for more details.
ilardig at svn.reactos.org
- [ros-diffs] [janderwald] 47782: [MMIXER] - Fix buffer overflow - Dedicated to irc:igorko
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47783: [PORTCLS] - Add sanity check
janderwald at svn.reactos.org
- [ros-diffs] [ekohl] 47784: [SYSSETUP] Set registry values 'PathName' and 'SystemRoot' in HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion. This fixes bug #4414.
ekohl at svn.reactos.org
- [ros-diffs] [janderwald] 47785: [PORTCLS] - Return better return code for unimplemented feature
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47786: [PORTCLS] - Fix infinite loop - Should fix gabriel_it and igorko1 problem with KsStudio - Add more debugging code to DumpFilterDescriptor
janderwald at svn.reactos.org
- [ros-diffs] [jgardou] 47787: [WIN32K] - Set DC_DIBSECTION dirty flag when a DIB section is selected, not when one is created.
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47788: [WIN32k] - Chek if there is something to do in GDIOBJ_SetOwnership before doing it
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47789: [WIN32K] - revert part of -r47735, as it's not the good fix (tm)
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47790: [RBUILD] - add missing file from a previous merge, which caused general failure of building the branch
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47791: [HAL] - yet another sync fun
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47792: one more step to fix svn mess
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47793: And now we welcome zlib to the great accomplishment of being correctly sync'ed with trunk
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47794: [ZLIB] [NTOSKRNL] This is the ultimate commit that makes this branch build again
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47795: Hopefully fail to break anything in the process of syncing with trunk (r47786)
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47796: [WIN32K] - Delete useless file once and for all
jgardou at svn.reactos.org
- [ros-diffs] [jgardou] 47797: [WIN32K] - apply r47787 to yarotows
jgardou at svn.reactos.org
- [ros-diffs] [fireball] 47798: [VENDOR/WINE] - Import Wine-1.2-rc3 gdi32, user32, winex11.drv, wineserver.
fireball at svn.reactos.org
- [ros-diffs] [ekohl] 47799: [NTOSKRNL] - Use the current partition descriptor to check for container partitions. Logical units in extended partitions become visible again but you cannot access them yet. This fixes the first half of bug #2564.
ekohl at svn.reactos.org
- [ros-diffs] [jgardou] 47800: [GDI32] - Use default LOGFONT in EnumFontFamilies. + ~3000 gdi32:font winetests
jgardou at svn.reactos.org
- [ros-diffs] [cgutman] 47801: [NTOSKRNL] - Fix a string termination bug in the device interface code - Thanks to janderwald for spotting the bug
cgutman at svn.reactos.org
- [ros-diffs] [jgardou] 47802: Merge 47800 from yarotows branch. Changelog should have been: [GDI32] - Use default LOGFONT in EnumFontFamilies if none is given. + ~3000 gdi32:font winetests
jgardou at svn.reactos.org
- [ros-diffs] [cgutman] 47803: [MSAFD] - Add locking to protect the socket list
cgutman at svn.reactos.org
- [ros-diffs] [janderwald] 47804: [SYSAUDIO] - Perform all allocations / frees in dedicated alloc / free function
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47805: [PORTCLS] - Fix buffer overflow
janderwald at svn.reactos.org
- [ros-diffs] [fireball] 47806: - Sync up to Wine-1.2-rc3.
fireball at svn.reactos.org
- [ros-diffs] [janderwald] 47807: [PORTCLS] - Check if resource list is provided - Fixes a crash for irc:igorko
janderwald at svn.reactos.org
- [ros-diffs] [khornicek] 47808: Reshuffle .rbuild entries so we have all files grouped by directories and in alphabetical order.
khornicek at svn.reactos.org
- [ros-diffs] [jgardou] 47809: apply 46848 from yarotows [WIN32K] - get rid of ROS_DC::BitsPerPixel. 1 - It was a hack. 2 - Its use was inconsistent.
jgardou at svn.reactos.org
- [ros-diffs] [ekohl] 47810: [NETEVENT] - Add new netevent.dll. It is a resource dll that will be used by the event log viewer.
ekohl at svn.reactos.org
- [ros-diffs] [tkreuzer] 47811: [MSVCRT] Convert to spec. Patch by Samuel Serapion.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47812: [MSVCRT] bring back _swprintf export
tkreuzer at svn.reactos.org
- [ros-diffs] [janderwald] 47813: [PORTCLS] - Support IDrmPort / IDrmPort2 for IPortWavePci driver
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47814: [PORTCLS] - Fix bug in the resource list object
janderwald at svn.reactos.org
- [ros-diffs] [cgutman] 47815: [NTOSKRNL] - Resource translation isn't very effective when we don't store the translated value in the translated descriptor (Fix a typo)
cgutman at svn.reactos.org
- [ros-diffs] [spetreolle] 47816: Update base address of comdlg32.
spetreolle at svn.reactos.org
- [ros-diffs] [janderwald] 47817: [PORTCLS] - Add sanity checks
janderwald at svn.reactos.org
- [ros-diffs] [tkreuzer] 47818: Sync to trunk (r47817)
tkreuzer at svn.reactos.org
- [ros-diffs] [janderwald] 47819: [PORTCLS] - Use FreeItem function for freeing memory instead of doing it directly
janderwald at svn.reactos.org
- [ros-diffs] [dreimer] 47820: Update the rapps download list. Fix the SeaMonkey Mirror.
dreimer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47821: [NTOSKRNL] Apply compilation fix for amd64
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47822: [CRT] - Stubplement _controlfp_s, rand_s - Implement _invalid_parameter, _get_invalid_parameter_handler, _set_invalid_parameter_handler - Implement memmove_s, strncpy_s - sync heap.c with wine Patch by Samuel Serapion
tkreuzer at svn.reactos.org
- [ros-diffs] [khornicek] 47823: [NTOSKRNL] Remove a superfluous assert (requested by sir_richard).
khornicek at svn.reactos.org
- [ros-diffs] [tkreuzer] 47824: [ODBC32] Merge 41027, 41028, 44611 from amd64 branch Update odbc32 to Wine-1.1.21.
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47825: [NDIS] - Dequeue the timer earlier so the timer queue will be in a valid state if any timers are modified during the miniport's timer callback
cgutman at svn.reactos.org
- [ros-diffs] [dreimer] 47826: Added comctl32.ocx, KDEWin, Mono, .net, Media Player Classic, Python, Steam, Tahoma Font and Windows Media Encoder 9 to rapps. Updated VB6, VC2005, VC2008 links according to winetricks.
dreimer at svn.reactos.org
- [ros-diffs] [cgutman] 47827: [NTOSKRNL] - Check that the caller passed a valid PDO pointer to IoOpenDeviceRegistryKey
cgutman at svn.reactos.org
- [ros-diffs] [pschweitzer] 47828: [NTOSKRNL] Add a macro to check for a valid PDO and use it in IoOpenDeviceRegistryKey(). Requested by sir_richard.
pschweitzer at svn.reactos.org
- [ros-diffs] [pschweitzer] 47829: [NTOSKRNL] Move the PDO check in IoOpenDeviceRegistryKey() to the function begin. Requested by sir_richard.
pschweitzer at svn.reactos.org
- [ros-diffs] [dreimer] 47830: Add Ukrainian Translations to rapps by Igor Paliychuk. Update VLC to 1.1.0
dreimer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47831: [OSKITTCP] Use RtlUlongByteSwap / RtlUshortByteSwap for byte swapping. They are portable and intrinsics on x86.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47832: [PRIMITIVES] - use pointer sized integers when converting handles
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47833: Sync to trunk (r47832)
tkreuzer at svn.reactos.org
- [ros-diffs] [spetreolle] 47834: Add leftover from sync, fixes build.
spetreolle at svn.reactos.org
- [ros-diffs] [tkreuzer] 47835: Leftover from the recent syncs
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47836: Rename a macro
tkreuzer at svn.reactos.org
- [ros-diffs] [pschweitzer] 47837: [IOEVENT] Added a library containing GUIDs for PnP notifications [BUGCODES] Added missing bugcheck code for PnP manager [NTOSKRNL] - Implemented FsRtlNotifyVolumeEvent() - Implemented IoReportTargetDeviceChange(), IoReportTargetDeviceChangeAsynchronous() - Craplemented PpSetCustomTargetEvent() to match our actual PnP manager notifications system. This is to be rewritten - Added support for custom notifications in IopNotifyPlugPlayNotification() - Added use of FsRtlNotifyVolumeEvent() in RawUserFsCtrl() to notify volume state changes - Added use of IoEvent library to ntoskrnl [FASTFAT] - Added use of FsRtlNotifyVolumeEvent() when successfully mounting a volume Finally, purpose of that patch is to implement volumes events notifications. Behaviour and implementation is correct till PpSetCustomTargetEvent(). The PnP notifications manager should be rewritten to match Microsoft's one. Furthermore, it appears that in Windows, those notifications are asynchronous.
pschweitzer at svn.reactos.org
- [ros-diffs] [dreimer] 47839: Ukrainian translation updates for usetup by Igor Paliychuk.
dreimer at svn.reactos.org
- [ros-diffs] [janderwald] 47840: [WDMAUD.DRV] - Fix compilation when using USE_MMIXER_LIB
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47841: [WDMAUD.DRV] - Fix compilation when using USE_MMIXER_LIB #2
janderwald at svn.reactos.org
- [ros-diffs] [janderwald] 47842: [WDMAUD.DRV] - Fix initialization of mmixer library
janderwald at svn.reactos.org
- [ros-diffs] [akhaldi] 47843: [PSDK] - Add several missing VER_* definitions.
akhaldi at svn.reactos.org
- [ros-diffs] [tkreuzer] 47844: [SUSPEND] Fix compilation for amd64
tkreuzer at svn.reactos.org
- [ros-diffs] [mjmartin] 47845: [usbehci] - Use the correct offset of ROOTHUB2_CONFIGURATION_DESCRIPTOR and ROOTHUB2_INTERFACE_DESCRIPTOR to calculate needed buffer sizes. Fixes a buffer overflow crash.
mjmartin at svn.reactos.org
- [ros-diffs] [tkreuzer] 47846: [UNIATA] Remove all the byteswap "optimisations" and use portable RTL byteswap functions
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47847: Fix a typo
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47848: [UNIATA] Merge from amd64 branch: 44634: Make x86 specific optimizations x86 specific, use macros otherwise. (Samuel Serapion) 44639: Try to fix numerous pointer to ULONG casts. (Samuel Serapion) 47846/47847: Remove all the byteswap "optimisations" and use portable RTL byteswap functions (Timo Kreuzer)
tkreuzer at svn.reactos.org
- [ros-diffs] [mjmartin] 47849: [win32k] - co_IntSendMessageWithCallBack is called for two reasons; for messages that originate from win32k and from user mode when using Callbacks. For both cases do not do anything with the sendqueue member of message struct and do not add the message to the senders dispatch message list. - In msgqueue related functions, check if the message is a nowait messages before attempting to remove and entry from the dispatch message list as it doesnt exist. - Fixes a NonPagedPool corruption that was occurring on regtest bootcd. Thanks Caemyr for testing.
mjmartin at svn.reactos.org
- [ros-diffs] [ekohl] 47850: [NTDLL] - Add RtlCreateBootStatusDataFile() stub.
ekohl at svn.reactos.org
- [ros-diffs] [ekohl] 47851: [FORMATTING] - Fix indentation.
ekohl at svn.reactos.org
- [ros-diffs] [tkreuzer] 47852: [DDK/XDK] Don't auto define NO_LEGACY_DRIVERS on reactos x64 builds.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47853: [USER32] ntstatus.h is in psdk, not in ddk folder. (How did this work?)
tkreuzer at svn.reactos.org
- [ros-diffs] [dreimer] 47854: Update reg, xcopy, winhlp32, wordpad to Wine 1.2rc5
dreimer at svn.reactos.org
- [ros-diffs] [dreimer] 47855: Update WineFile to Wine 1.2rc5
dreimer at svn.reactos.org
- [ros-diffs] [ekohl] 47856: [EVENTVWR] - Replace hard-coded column names by string resources.
ekohl at svn.reactos.org
- [ros-diffs] [spetreolle] 47857: french translation for eventvwr
spetreolle at svn.reactos.org
- [ros-diffs] [ilardig] 47858: [EVENTVWR] - Update Italian and Spanish translations
ilardig at svn.reactos.org
- [ros-diffs] [mjmartin] 47859: [win32k] - Add Check for spwndNext being null before accessing any of the members. Fixes bugcheck when using cubicexplorer.
mjmartin at svn.reactos.org
- [ros-diffs] [spetreolle] 47860: update olepro32 base address.
spetreolle at svn.reactos.org
- [ros-diffs] [fireball] 47861: [VENDOR/WINE] - Import Wine-1.2-rc5 gdi32, user32, winex11.drv.
fireball at svn.reactos.org
- [ros-diffs] [tkreuzer] 47862: The Win32ClientInfo TEB field can be bigger than the CLIENTINFO structure.
tkreuzer at svn.reactos.org
- [ros-diffs] [cgutman] 47863: [MSAFD] - Handle the case (again) where we get passed an invalid lpErrno pointer to a WSP function - Fixes some crashes I encountered when running Opera 9
cgutman at svn.reactos.org
- [ros-diffs] [sir_richard] 47864: [NTOS]: Warn only once about MmLockPageableImageSection being unimplemented.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47865: - There's no such thing as PRTL_MESSAGE_RESOURCE_ENTRY, use PMESSAGE_RESOURCE_ENTRY instead.
sir_richard at svn.reactos.org
- [ros-diffs] [cgutman] 47866: [DHCPCSVC] - Use an event to signal when an adapter has been added
cgutman at svn.reactos.org
- [ros-diffs] [sir_richard] 47867: [MC]: Add pciclass.mc required for eVb's PCI driver. Matches resource data in Windows driver, minus typos.
sir_richard at svn.reactos.org
- [ros-diffs] [ekohl] 47868: [NTOSKRNL] NtDuplicateToken: Fail, if TokenType is neither TokenImpersonation nor TokenPrimary.
ekohl at svn.reactos.org
- [ros-diffs] [sir_richard] 47869: [NTOS]: My SVN is haunted. Commit missing changes?
sir_richard at svn.reactos.org
- [ros-diffs] [pschweitzer] 47870: Fix ARM build
pschweitzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47871: [NTOS]: I am sorry, this is embarssing. Fix build again.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47872: [NTOS]: Add "vf" NTOS component, required NDK headers, and enable exports required for PCI driver to load.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47873: [NTOS]: VfFailDeviceNode is actuall __cdecl. [NTOS]: Sort, update, clean-up, and add descriptions to bugcodes.mc.
sir_richard at svn.reactos.org
- [ros-diffs] [akhaldi] 47874: Fix Build. Seriously this time ;)
akhaldi at svn.reactos.org
- [ros-diffs] [fireball] 47875: [NTOS] - Warn only once in MmSecureVirtualMemory/MmUnsecureVirtualMemory, like it was done in 47864.
fireball at svn.reactos.org
- [ros-diffs] [sir_richard] 47876: [NDK]: Not Alex, not 2006, not February (27th, though), not Power Management.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47877: [FORMATTING] - Fix broken indentation
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47878: [USER32] - Use UlongToHandle instead of LongToHandle - case to ULONG_PTR instead of using HandleToUlong - SetSysColorsTemp: don't truncate the pointer sized n value, remove a comment - IntGetClsWndProc: fix a bug - IntGetWindowLong: pass !unicode to IntGetWndProc
tkreuzer at svn.reactos.org
- [ros-diffs] [akhaldi] 47879: Fix a warning (treated as an error).
akhaldi at svn.reactos.org
- [ros-diffs] [tkreuzer] 47880: [KERNEL32] Fix the pspec file
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47881: [BOOTDATA]: Add the 176 different PCI devices that Windows knows about, and the erratas that need to be applied to make those devices work correctly. This information is processed by eVb's PCI Bus driver. 3rd-party device manufacturers, as well as Microsoft online support pages, sometimes instruct users to add new entries to this list as well, and new entries are also added by 3rd-party driver .INF files. Probably 30% of computers in the world have at least one of these devices installed.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47882: Make the uiLo and uiHi members of the KMDDELPARAM structure UINT_PTRs
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47883: [PCI]: Add the 40 different PCI erratas ("hack flags") that Windows can apply to broken PCI devices. eVb's driver knowss to apply these by parsing the PCI\Parameters list. These are the actual internal symbolic names used by Microsoft, which accidentally leaked out in the Vista Errata Manager .INF file.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47884: [USER32] Merge from amd64 branch: 36987: - Fix user32 compilation errors. (Samuel Serapion) 36988: - Make user32 compile and link by defining Get/SetClass/WindowLongPtrA/W (Stefan Ginsberg) 41480: - Fix 64bit issues, add a wine compatibility hack (Timo Kreuzer) 41540: - Make parameters for NtUserCallOneParam and NtUserCallTwoParam DWORD_PTR instead of DWORD (Timo Kreuzer) 43965: (Samuel Serapion) - Fix several user32 warnings. - Sync GetWindow*A/W with wine and unify all versions, commenting out a wine hack. - As a bonus implement GetWindowLongPtrA/W. - Tested to work in trunk. 43992: - Fix user32 build. (Samuel Serapion) 45124: - Fix user32 build. (Samuel Serapion) 47472: - Remove wine hack and allow user32 to compile again. (Samuel Serapion) 47878: (Timo Kreuzer) - Use UlongToHandle instead of LongToHandle - case to ULONG_PTR instead of using HandleToUlong - SetSysColorsTemp: don't truncate the pointer sized n value, remove a comment - IntGetClsWndProc: fix a bug - IntGetWindowLong: pass !unicode to IntGetWndProc 47882: - Make the uiLo and uiHi members of the KMDDELPARAM structure UINT_PTRs (Timo Kreuzer)
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47885: [PCI]: Add the PCI_ENABLE_BRIDGE definitions that can be present in PCI_COMMON_CONFIG/type1/BridgeControl. Microsoft does not document these in the public PCI headers, but the definitions were found in the Singularity headers. eVb's PCI driver uses these.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47886: [PCI]: Add PCI IRQ Routing Table structure to Shared, Internal PCI Header (based off the Microsoft Spec and the Apple SMBIOS Header). [PCI]: Remove HAL-internal PCI definitions from the existing "Shared/Internal" PCI Header which existed in NTOS's private include directory, and move them to HAL-internal headers. [PCI]: Remove remaining shared PCI definitions from that same header, and put them in the new Shared/Internal PCI Header. [PCI]: Remove duplicated PCI definitions from FreeLDR, and use thw new Shared/Internal PCI Header.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47887: [PCI]: Add pciclass.rc to use the pciclass.mc/res-generated file by MC. eVb can now start committing his driver.
sir_richard at svn.reactos.org
- [ros-diffs] [tkreuzer] 47888: build w32knapi only for x86
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47889: usurp: Physicus: better use </if> in .rbuild ; ) So be it.
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47890: [WINED3D] Fix prototype of wined3d_event_query_supported (BOOL != HRESULT)
tkreuzer at svn.reactos.org
- [ros-diffs] [sir_richard] 47892: [ACPI]: Share ACPI table structures and NT-specific registry data in a shared, internal ACPI header, instead of HAL's internal headers, because FreeLDR, the kernel's PnP Manager, the PCI Bus Driver and the ACPI Driver all need access to these types as well.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47893: [NDK]: Add some missing RTL Range Functions needed by eVb.
sir_richard at svn.reactos.org
- [ros-diffs] [evb] 47894: Begin implement full PCI Bus Driver. code by me comments by sir_richard to avoid Engrish DriverEntry full 100% implemented, ACPI WatchDog detect, PCI IRQ Routing detect, PCI errata/hackflag detect (PciGetDebugPorts not support, need PCI Debug Device to test) Native (S)ATA, PCI BIOS Resource Lock, System Errata/Hackflag also is detect HAL Hoooking enabled, callbacks stub Stub PnP Interfaces: PciAddDevice, PciDriverUnload, PciDispatchIrp PCI utility routines: PciUnicodeStringStrStr, PciStringToUSHORT, PciIsSuiteVersion, PciIsDatacenter, PciOpenKey, PciGetRegistryValue, PciBuildDefaultExclusionList done PCI Verifier Support for future: PciVerifierInit/PciVerifierProfileChangeCallback (stub) Thank you for much patience~ This 1200 first codes, have 12000 codes more to come!~~
evb at svn.reactos.org
- [ros-diffs] [spetreolle] 47896: Fix midiOutOpen and midiInOpen prototypes.
spetreolle at svn.reactos.org
- [ros-diffs] [evb] 47897: Missing PCI_BUS_DRIVER_INTERNAL added to bugcodes. Thx for sir_richard to show me how to add.
evb at svn.reactos.org
- [ros-diffs] [evb] 47898: Implement Root Bus FDO AddDevice codes, get boot config, connect to HAL or ACPI config handlers (PciQueryForPciBusInterface, PciGetConfigHandlers), read BUS FDO hack flag, get _HPP HotPlug PCI ACPI data and initialize arbiter support. PciGetHotPlugParameters work but no PCI HotPlug support on my machines, so cannot test ACPI data, that part stub now Add PciFdoDispatchTable, PciFdoDispatchPnpTable, PciFdoDispatchPowerTable but all stub to PciIrpNotSupported however set correct IRP Dispatch Style for the IRPS Arbiter support in PciInitializeARbiters done, but PciInterfaces array is NULL (stub) at moment Add PCI_SIGNATURE, PCI_STATE, PCI_DISAPTCH_STYLE type, add PciInitializeState to begin the state support Add structure for PCI_FDO_EXTENSION, PCI_SECONDARY_EXTENSION, PCI_INTERFACE, PCI_ARBITER_INSTANCE, PCI_DISPATCH_TABLE PCI utility functions added: PciFindParentPciFdoExtension, PciInsertEntryAtTail, PciInsertEntryAtHead, PcipLinkSecondaryExtension, PciGetDeviceProperty, PciSendIoctl Need sir_richard to add arbiter.h header to define ARBITER_INSTANCE for finish support This 1000 more codes done now~
evb at svn.reactos.org
- [ros-diffs] [cgutman] 47899: [DHCPCSVC] - Discover adapters synchronously again until a bug (possibly a race condition) is fixed - DHCP failure in certain situations is fixed now
cgutman at svn.reactos.org
- [ros-diffs] [tkreuzer] 47900: [WINMM] Fix a number of 64bit issues, add some comments where the code is not 64 bit safe. This module should be synced with wine, but this still causes a problem with Flash videos on FF2 (likely another timer problem)
tkreuzer at svn.reactos.org
- [ros-diffs] [tkreuzer] 47901: [WS2_32_NEW] Fix WSAAccept parameter (DWORD -> DWORD_PTR)
tkreuzer at svn.reactos.org
- [ros-diffs] [dreimer] 47902: Update Thunderbird and FireFox in rapps.
dreimer at svn.reactos.org
- [ros-diffs] [fireball] 47903: - Sync up to Wine-1.2-rc5.
fireball at svn.reactos.org
- [ros-diffs] [fireball] 47904: - Merge 47605.
fireball at svn.reactos.org
- [ros-diffs] [ilardig] 47905: [EVENTVWR] - Polish update by Maciej Bialas.
ilardig at svn.reactos.org
- [ros-diffs] [mjmartin] 47906: [win32k] - Change percision of win32k timers to 0.5 miliseconds. - Remove Destroy parameter from FindTimer as it is just odd and call RemoveTimer where needed. - PostTimerMessages: No need to continue looping the remainder of the timers once the target timer has been found and message posted to message queue.
mjmartin at svn.reactos.org
- [ros-diffs] [sir_richard] 47907: [RTL]: RangeList APIs should not be allocating pool with a tag of 0, since this makes the checked kernel ASSERT. Good thing nobody used these APIs (I wonder if they even work), but eVb's PCI driver now does.
sir_richard at svn.reactos.org
- [ros-diffs] [sir_richard] 47908: [PCIX]: Fix 17 different bugs in the new PCI driver. ACPI and PCI IRQ Routing table detection now works, ACPI table mapping doesn't crash anymore, PciGetRegistryValue doens't always fail, some DPRINTs fixed, added missing "continues", "breaks", and early-"returns". Fixed missing, or extra "!"s. If you're going to try being clever with do while FALSE loops, get 'em right! The driver now works up to the point where eVb has last committed his code.
sir_richard at svn.reactos.org
- [ros-diffs] [janderwald] 47909: [PORTCLS] - Check if there is a silence buffer available when there is no audio mapping available - ignore failure for allocation requirements
janderwald at svn.reactos.org
- [ros-diffs] [fireball] 47910: - Giannis Adamopoulos: Never allow bringing shell window to foreground in SWM.
fireball at svn.reactos.org
- [ros-diffs] [jimtabor] 47911: [Win32k] - Set caret blink rate for global server information too.
jimtabor at svn.reactos.org
- [ros-diffs] [evb] 47912: Implemented IRP dispatch to work in new PCI driver (PciDispatchIrp), fill out FDO IRP handlers which all stubs now, make up/down-call work (PciPassIrpFromFdoToPdo, PciPassDownIrp) Added the helper debug routines PCI driver receive IRP_QUERY_INTERFACE now and hit stub
evb at svn.reactos.org
- [ros-diffs] [dreimer] 47913: Add Visual C++ 2008 SP1 runtime to rapps and rename the others correctly.
dreimer at svn.reactos.org
- [ros-diffs] [dreimer] 47914: Added Fox Audio Player to rapps and some more fixes. (Igor Paliychuk, myself)
dreimer at svn.reactos.org
- [ros-diffs] [mjmartin] 47915: [win32k] - Remove dead code as in the old SetTimer and KillTimer functions.
mjmartin at svn.reactos.org
- [ros-diffs] [spetreolle] 47916: Fix typo. Dedicated to Physicus
spetreolle at svn.reactos.org
- [ros-diffs] [mkupfer] 47917: - move set of msg-time (for messages) back to msg queue (msg time is needed for all mouse events not only mouse move) - ClickLock will work again
mkupfer at svn.reactos.org
- [ros-diffs] [akhaldi] 47918: [PSDK] - Fix EVENT_FILTER_DESCRIPTOR redefinition.
akhaldi at svn.reactos.org
Last message date:
Wed Jun 30 19:36:38 UTC 2010
Archived on: Wed Jun 30 19:36:40 UTC 2010
This archive was generated by
Pipermail 0.09 (Mailman edition).