[ros-diffs] [tkreuzer] 45997: [WDM] reenable the ASSERT in IoSkipCurrentIrpStackLocation
tkreuzer at svn.reactos.org
tkreuzer at svn.reactos.org
Mon Mar 8 06:00:38 CET 2010
- Previous message: [ros-diffs] [tkreuzer] 45996: [NTOS] IofCompleteRequest: Skip the stack location at the beginning of the loop instead of before and at the end to avoid double skipping of the last valid stack location in certain cases. This prevents the ASSERT in IoSkipCurrentIrpStackLocation to be hit. Note: this leads to a different value of Irp->CurrentLocation and Irp->Tail.Overlay.CurrentStackLocation after the last completion routine has been called. But that should hopefully not make a difference.
- Next message: [ros-diffs] [akhaldi] 45998: [NTIFS] - Group related definitions - Add Nt{Open,Privilege,Close,Delete}ObjectAuditAlarm, NtPrivilegedServiceAuditAlarm, RtlRandom(Ex), RtlCaptureContext, RtlInit{Ansi,Unicode}StringEx, RtlUpcaseUnicodeStringTo(Counted)OemString, RtlIdnTo(Nameprep)Unicode, RtlValidateUnicodeString, RtlUnicodeStringToOemSize, RtlMultiByteToUnicodeN, RtlMultiByteToUnicodeSize, RtlUnicodeToMultiByteSize, RtlUnicodeToUTF8N, RtlUTF8ToUnicodeN, RtlUpcaseUnicodeToMultiByteN, RtlUnicodeToOemN, RtlUpcaseUnicodeToOemN, RtlNormalizeString, RtlIsNormalizedString, RtlIsValidOemCharacter, PfxInitialize, PfxInsertPrefix, RtlEqualPrefixSid, RtlFreeSid, RtlAllocateAndInitializeSid and RtlIdentifierAuthoritySid function declarations - Add RTL_ALLOCATE_STRING_ROUTINE, RTL_REALLOCATE_STRING_ROUTINE and RTL_FREE_STRING_ROUTINE type definitions - Add PREFIX_TABLE_ENTRY and PREFIX_TABLE structures - Improve RtlGenerate8dot3Name definition - Improve RtlFillMemoryUlong and add RtlFillMemoryUlonglong - Add HEAP_SETTABLE_USER_{VALUE,FLAG1,FLAG2,FLAG3,FLAGS}, HEAP_CLASS_{0-8,MASK}, HEAP_MAXIMUM_TAG, HEAP_GLOBAL_TAG, HEAP_PSEUDO_TAG_FLAG, HEAP_TAG_SHIFT, HEAP_TAG_MASK and HEAP_CREATE_VALID_MASK definitions - Add HEAP_MAKE_TAG_FLAGS inline function - RtlAllocateHeap : HANDLE HeapHandle -> PVOID HeapHandle - RtlFreeHeap : HANDLE HeapHandle -> PVOID HeapHandle and P -> BaseAddress - RtlOemToUnicodeN : PCH OemString -> PCCH OemString - Add RtlOffsetToPointer and RtlPointerToOffset macros Dedicated to arty ; )
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: tkreuzer
Date: Mon Mar 8 06:00:38 2010
New Revision: 45997
URL: http://svn.reactos.org/svn/reactos?rev=45997&view=rev
Log:
[WDM]
reenable the ASSERT in IoSkipCurrentIrpStackLocation
Modified:
branches/header-work/include/ddk/wdm.h
Modified: branches/header-work/include/ddk/wdm.h
URL: http://svn.reactos.org/svn/reactos/branches/header-work/include/ddk/wdm.h?rev=45997&r1=45996&r2=45997&view=diff
==============================================================================
--- branches/header-work/include/ddk/wdm.h [iso-8859-1] (original)
+++ branches/header-work/include/ddk/wdm.h [iso-8859-1] Mon Mar 8 06:00:38 2010
@@ -8929,7 +8929,7 @@
IoSkipCurrentIrpStackLocation (
IN OUT PIRP Irp)
{
- //ASSERT(Irp->CurrentLocation <= Irp->StackCount); FIXME: ReactOS is broken!
+ ASSERT(Irp->CurrentLocation <= Irp->StackCount);
Irp->CurrentLocation++;
Irp->Tail.Overlay.CurrentStackLocation++;
}
- Previous message: [ros-diffs] [tkreuzer] 45996: [NTOS] IofCompleteRequest: Skip the stack location at the beginning of the loop instead of before and at the end to avoid double skipping of the last valid stack location in certain cases. This prevents the ASSERT in IoSkipCurrentIrpStackLocation to be hit. Note: this leads to a different value of Irp->CurrentLocation and Irp->Tail.Overlay.CurrentStackLocation after the last completion routine has been called. But that should hopefully not make a difference.
- Next message: [ros-diffs] [akhaldi] 45998: [NTIFS] - Group related definitions - Add Nt{Open,Privilege,Close,Delete}ObjectAuditAlarm, NtPrivilegedServiceAuditAlarm, RtlRandom(Ex), RtlCaptureContext, RtlInit{Ansi,Unicode}StringEx, RtlUpcaseUnicodeStringTo(Counted)OemString, RtlIdnTo(Nameprep)Unicode, RtlValidateUnicodeString, RtlUnicodeStringToOemSize, RtlMultiByteToUnicodeN, RtlMultiByteToUnicodeSize, RtlUnicodeToMultiByteSize, RtlUnicodeToUTF8N, RtlUTF8ToUnicodeN, RtlUpcaseUnicodeToMultiByteN, RtlUnicodeToOemN, RtlUpcaseUnicodeToOemN, RtlNormalizeString, RtlIsNormalizedString, RtlIsValidOemCharacter, PfxInitialize, PfxInsertPrefix, RtlEqualPrefixSid, RtlFreeSid, RtlAllocateAndInitializeSid and RtlIdentifierAuthoritySid function declarations - Add RTL_ALLOCATE_STRING_ROUTINE, RTL_REALLOCATE_STRING_ROUTINE and RTL_FREE_STRING_ROUTINE type definitions - Add PREFIX_TABLE_ENTRY and PREFIX_TABLE structures - Improve RtlGenerate8dot3Name definition - Improve RtlFillMemoryUlong and add RtlFillMemoryUlonglong - Add HEAP_SETTABLE_USER_{VALUE,FLAG1,FLAG2,FLAG3,FLAGS}, HEAP_CLASS_{0-8,MASK}, HEAP_MAXIMUM_TAG, HEAP_GLOBAL_TAG, HEAP_PSEUDO_TAG_FLAG, HEAP_TAG_SHIFT, HEAP_TAG_MASK and HEAP_CREATE_VALID_MASK definitions - Add HEAP_MAKE_TAG_FLAGS inline function - RtlAllocateHeap : HANDLE HeapHandle -> PVOID HeapHandle - RtlFreeHeap : HANDLE HeapHandle -> PVOID HeapHandle and P -> BaseAddress - RtlOemToUnicodeN : PCH OemString -> PCCH OemString - Add RtlOffsetToPointer and RtlPointerToOffset macros Dedicated to arty ; )
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list