[ros-diffs] [akhaldi] 52904: [TELNET] * Introduce a PCH. * BTW, the recent and upcoming changes are two-fold: First, having a precompiled header will increase build speed. Furthermore, PCH support allows CMake...

akhaldi at svn.reactos.org akhaldi at svn.reactos.org
Tue Jul 26 21:56:49 UTC 2011


Author: akhaldi
Date: Tue Jul 26 21:56:48 2011
New Revision: 52904

URL: http://svn.reactos.org/svn/reactos?rev=52904&view=rev
Log:
[TELNET]
* Introduce a PCH.
* BTW, the recent and upcoming changes are two-fold: First, having a precompiled header will increase build speed. Furthermore, PCH support allows CMake dependency tracking files to shrink drastically. For example it's (depend.make) 95% smaller for this module than it used to be. This means an even better build system compared to rbuild, not to mention it's now faster than before.
* This work is dedicated to Jerome.

Added:
    trunk/reactos/base/applications/network/telnet/src/precomp.h   (with props)
Modified:
    trunk/reactos/base/applications/network/telnet/CMakeLists.txt
    trunk/reactos/base/applications/network/telnet/src/ansiprsr.cpp
    trunk/reactos/base/applications/network/telnet/src/keytrans.cpp
    trunk/reactos/base/applications/network/telnet/src/tcharmap.cpp
    trunk/reactos/base/applications/network/telnet/src/tconsole.cpp
    trunk/reactos/base/applications/network/telnet/src/tkeydef.cpp
    trunk/reactos/base/applications/network/telnet/src/tkeymap.cpp
    trunk/reactos/base/applications/network/telnet/src/tmapldr.cpp
    trunk/reactos/base/applications/network/telnet/src/tmouse.cpp
    trunk/reactos/base/applications/network/telnet/src/tnclass.cpp
    trunk/reactos/base/applications/network/telnet/src/tnclip.cpp
    trunk/reactos/base/applications/network/telnet/src/tncon.cpp
    trunk/reactos/base/applications/network/telnet/src/tnconfig.cpp
    trunk/reactos/base/applications/network/telnet/src/tnerror.cpp
    trunk/reactos/base/applications/network/telnet/src/tnetwork.cpp
    trunk/reactos/base/applications/network/telnet/src/tnmain.cpp
    trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp
    trunk/reactos/base/applications/network/telnet/src/tscript.cpp
    trunk/reactos/base/applications/network/telnet/src/tscroll.cpp
    trunk/reactos/base/applications/network/telnet/src/ttelhndl.cpp

Modified: trunk/reactos/base/applications/network/telnet/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/CMakeLists.txt?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/CMakeLists.txt [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -26,5 +26,6 @@
     telnet.rc)
 
 set_module_type(telnet win32cui)
+add_pch(telnet src/precomp.h)
 add_importlibs(telnet ws2_32 user32 msvcrt kernel32)
 add_cd_file(TARGET telnet DESTINATION reactos/system32 FOR all)

Modified: trunk/reactos/base/applications/network/telnet/src/ansiprsr.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/ansiprsr.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/ansiprsr.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/ansiprsr.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -50,8 +50,7 @@
 ///////////////////////////////////////////////////////////////////////////////
 
 //#include <windows.h>
-#include <string.h>
-#include "ansiprsr.h"
+#include "precomp.h"
 
 const int ANSIColors[] = {BLACK, RED, GREEN, YELLOW, BLUE, MAGENTA, CYAN, WHITE};
 

Modified: trunk/reactos/base/applications/network/telnet/src/keytrans.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/keytrans.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/keytrans.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/keytrans.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -44,21 +44,7 @@
 //  DeleteKeyDef  : Deletes a key def from the list              //
 ///////////////////////////////////////////////////////////////////
 
-#include <windows.h>
-
-// changed to make work with VC++ (Paul Brannan 5/25/98)
-// FIX ME !!! Ioannou:  This must be __BORLANDC__ && VERSION < 5
-// but what is the directive for Borland version ????
-// FIXED Sept. 31, 2000 (Bernard Badger)
-//
-#if defined(__BORLANDC__) && (__BORLANDC < 0x0500)
-#include <mem.h>
-#else
-#include <memory.h>
-#endif
-
-#include "keytrans.h"
-#include "tnerror.h"
+#include "precomp.h"
 
 /////////////////////////////////////////////////////////////
 //                class KeyTranslator                      //

Added: trunk/reactos/base/applications/network/telnet/src/precomp.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/precomp.h?rev=52904&view=auto
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/precomp.h (added)
+++ trunk/reactos/base/applications/network/telnet/src/precomp.h [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -1,0 +1,47 @@
+#include "ansiprsr.h"
+
+#if defined(__BORLANDC__) && (__BORLANDC < 0x0500)
+#include <mem.h>
+#else
+#include <memory.h>
+#endif
+
+#ifdef __BORLANDC__
+#include <fstream.h>
+#else
+#include <string>
+#include <fstream>
+#endif
+
+#include <windows.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <stdarg.h>
+#include <string.h>
+#include <locale.h>
+#include <io.h>
+#include <time.h>
+#include <ctype.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#include "keytrans.h"
+#include "tnerror.h"
+#include "tcharmap.h"
+#include "tnconfig.h"
+#include "tconsole.h"
+#include "tkeydef.h"
+#include "tkeymap.h"
+#include "tmapldr.h"
+#include "tmouse.h"
+#include "tnclass.h"
+#include "tnmisc.h"
+#include "tnclip.h"
+#include "tncon.h"
+#include "ttelhndl.h"
+#include "tnetwork.h"
+#include "tnmain.h"
+#include "tscript.h"
+#include "tscroll.h"
+#include "telnet.h"
+#include "tparams.h"

Propchange: trunk/reactos/base/applications/network/telnet/src/precomp.h
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: trunk/reactos/base/applications/network/telnet/src/tcharmap.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tcharmap.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tcharmap.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tcharmap.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -28,9 +28,7 @@
 // Written by Paul Brannan <pbranna at clemson.edu>
 // Last modified 7/12/98
 
-#include <string.h>
-#include "tcharmap.h"
-#include "tnconfig.h"
+#include "precomp.h"
 
 // map B (US ASCII)
 // this maps each character to itself

Modified: trunk/reactos/base/applications/network/telnet/src/tconsole.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tconsole.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tconsole.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tconsole.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -46,8 +46,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include <windows.h>
-#include "tconsole.h"
+#include "precomp.h"
 
 // argsused doesn't work on MSVC++
 #ifdef __BORLANDC__

Modified: trunk/reactos/base/applications/network/telnet/src/tkeydef.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tkeydef.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tkeydef.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tkeydef.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -29,8 +29,7 @@
 //     originally part of KeyTrans.cpp                 //
 /////////////////////////////////////////////////////////
 
-#include "tkeydef.h"
-#include <string.h>
+#include "precomp.h"
 
 // This class did not properly release memory before, and a buffer overrun
 // was apparent in operator=(char*).  Fixed.  (Paul Brannan Feb. 4, 1999)

Modified: trunk/reactos/base/applications/network/telnet/src/tkeymap.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tkeymap.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tkeymap.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tkeymap.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -29,7 +29,7 @@
 //     originally part of KeyTrans.cpp                 //
 /////////////////////////////////////////////////////////
 
-#include "tkeymap.h"
+#include "precomp.h"
 
 KeyMap::KeyMap(DWORD state, DWORD code): map(0,0,sizeof(TKeyDef)),
                                          key(NULL,state,code) {};

Modified: trunk/reactos/base/applications/network/telnet/src/tmapldr.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tmapldr.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tmapldr.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tmapldr.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -29,15 +29,7 @@
 //     originally part of KeyTrans.cpp                 //
 /////////////////////////////////////////////////////////
 
-#include "tmapldr.h"
-#include "tnconfig.h"
-
-#ifdef __BORLANDC__
-#include <fstream.h>
-#else
-#include <string>
-#include <fstream>
-#endif
+#include "precomp.h"
 
 // It's probably a good idea to turn off the "identifier was truncated" warning
 // in MSVC (Paul Brannan 5/25/98)

Modified: trunk/reactos/base/applications/network/telnet/src/tmouse.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tmouse.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tmouse.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tmouse.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -28,8 +28,7 @@
 // Written by Paul Brannan <pbranna at clemson.edu>
 // Last modified August 30, 1998
 
-#include "tmouse.h"
-#include "tconsole.h"
+#include "precomp.h"
 
 TMouse::TMouse(Tnclip &RefClipboard): Clipboard(RefClipboard) {
 	hConsole = GetStdHandle(STD_INPUT_HANDLE);

Modified: trunk/reactos/base/applications/network/telnet/src/tnclass.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnclass.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnclass.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnclass.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -41,10 +41,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include <stdlib.h>
-#include <string.h>
-#include "tnclass.h"
-#include "tnmisc.h"
+#include "precomp.h"
 
 // Mingw32 needs these (Paul Brannan 9/4/98)
 #ifndef ICON_SMALL

Modified: trunk/reactos/base/applications/network/telnet/src/tnclip.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnclip.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnclip.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnclip.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -28,8 +28,7 @@
 // Written by Paul Brannan <pbranna at clemson.edu>
 // Last modified 7/12/98
 
-#include <string.h>
-#include "tnclip.h"
+#include "precomp.h"
 
 Tnclip::Tnclip(HWND W, TNetwork &RefNetwork): Network(RefNetwork) {
 	Window = W;

Modified: trunk/reactos/base/applications/network/telnet/src/tncon.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tncon.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tncon.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tncon.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -43,10 +43,8 @@
 //					  Original code
 //
 ///////////////////////////////////////////////////////////////////////////////
-#include "tncon.h"
-#include "keytrans.h"
-#include "ttelhndl.h"
-#include "tconsole.h"
+
+#include "precomp.h"
 
 #define KEYEVENT InputRecord[i].Event.KeyEvent
 

Modified: trunk/reactos/base/applications/network/telnet/src/tnconfig.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnconfig.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnconfig.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnconfig.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -30,14 +30,7 @@
 // This is a class designed for use with Brad Johnson's Console Telnet
 // see the file tnconfig.h for more information
 
-#include <stdlib.h>
-#include <string.h>
-#include <locale.h>
-#include <memory.h>
-#include <io.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include "tnconfig.h"
+#include "precomp.h"
 
 // Turn off the "forcing value to bool 'true' or 'false'" warning
 #ifdef _MSC_VER

Modified: trunk/reactos/base/applications/network/telnet/src/tnerror.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnerror.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnerror.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnerror.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -42,13 +42,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include "tnerror.h"
-#include "ttelhndl.h"			// Paul Brannan 5/25/98
-#include "tnconfig.h"		// Paul Brannan 5/25/98
-#include <time.h>
-#include <stdio.h>
-#include <stdarg.h>
-#include <stdlib.h>
+#include "precomp.h"
 
 #ifndef LANG_USER_DEFAULT
 #define LANG_USER_DEFAULT 400

Modified: trunk/reactos/base/applications/network/telnet/src/tnetwork.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnetwork.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnetwork.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnetwork.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -35,7 +35,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include "tnetwork.h"
+#include "precomp.h"
 
 void TNetwork::SetSocket(SOCKET s) {
 	socket = s;

Modified: trunk/reactos/base/applications/network/telnet/src/tnmain.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnmain.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnmain.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnmain.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -42,10 +42,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include <string.h>
-#include <locale.h>
-#include "tnmain.h"
-#include "tnmisc.h"
+#include "precomp.h"
 
 int telCommandLine (Telnet &MyConnection);
 

Modified: trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tnmisc.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -1,7 +1,4 @@
-#include <windows.h>
-#include <stdio.h>
-
-#include "tnmisc.h"
+#include "precomp.h"
 
 // from the PVAX (http://www.ccas.ru/~posp/popov/spawn.htm)
 // Create a process with pipes to stdin/out/err

Modified: trunk/reactos/base/applications/network/telnet/src/tscript.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tscript.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tscript.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tscript.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -23,7 +23,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////
 
-#include "tscript.h"
+#include "precomp.h"
 
 // FIX ME!!  This code not yet functional.
 

Modified: trunk/reactos/base/applications/network/telnet/src/tscroll.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/tscroll.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/tscroll.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/tscroll.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -38,13 +38,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include <windows.h>
-#include <string.h>
-#include <ctype.h>
-#include "tscroll.h"
-#include "tncon.h"
-#include "tconsole.h"
-#include "tnconfig.h"
+#include "precomp.h"
 
 enum {
 	HEX,

Modified: trunk/reactos/base/applications/network/telnet/src/ttelhndl.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/telnet/src/ttelhndl.cpp?rev=52904&r1=52903&r2=52904&view=diff
==============================================================================
--- trunk/reactos/base/applications/network/telnet/src/ttelhndl.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/network/telnet/src/ttelhndl.cpp [iso-8859-1] Tue Jul 26 21:56:48 2011
@@ -38,11 +38,7 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include <string.h>
-#include "ttelhndl.h"
-#include "telnet.h"
-#include "tnconfig.h"
-#include "tparams.h"
+#include "precomp.h"
 
 int naws_string(char *buf, int width, int height);
 




More information about the Ros-diffs mailing list