[ros-diffs] [gadamopoulos] 53946: [win32k] - Fix RECTL_bPointInRect to work like PtInRect - Use the fixed RECTL_bPointInRect in DIB_XXBPP_FloodFillSolid to fix a bugchek See issue #6437 for more details.

gadamopoulos at svn.reactos.org gadamopoulos at svn.reactos.org
Sun Oct 2 23:09:03 UTC 2011


Author: gadamopoulos
Date: Sun Oct  2 23:09:03 2011
New Revision: 53946

URL: http://svn.reactos.org/svn/reactos?rev=53946&view=rev
Log:
[win32k]
- Fix RECTL_bPointInRect to work like PtInRect
- Use the fixed RECTL_bPointInRect in DIB_XXBPP_FloodFillSolid to fix a bugchek
See issue #6437 for more details.

Modified:
    trunk/reactos/subsystems/win32/win32k/dib/floodfill.c
    trunk/reactos/subsystems/win32/win32k/include/rect.h

Modified: trunk/reactos/subsystems/win32/win32k/dib/floodfill.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/dib/floodfill.c?rev=53946&r1=53945&r2=53946&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/dib/floodfill.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/dib/floodfill.c [iso-8859-1] Sun Oct  2 23:09:03 2011
@@ -59,8 +59,7 @@
                                   ULONG Color, 
                                   BOOL isSurf)
 {
-  if (x >= DstRect->left && x <= DstRect->right &&
-    y >= DstRect->top && y <= DstRect->bottom)
+  if (RECTL_bPointInRect(DstRect,x,y))
   {
     if (isSurf == TRUE && 
       DibFunctionsForBitmapFormat[DstSurf->iBitmapFormat].DIB_GetPixel(DstSurf, x, y) != Color)

Modified: trunk/reactos/subsystems/win32/win32k/include/rect.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/include/rect.h?rev=53946&r1=53945&r2=53946&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/include/rect.h [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/include/rect.h [iso-8859-1] Sun Oct  2 23:09:03 2011
@@ -41,8 +41,8 @@
 FORCEINLINE
 RECTL_bPointInRect(const RECTL *prcl, INT x, INT y)
 {
-    return (x >= prcl->left && x <= prcl->right &&
-            y >= prcl->top  && y <= prcl->bottom);
+    return (x >= prcl->left && x < prcl->right &&
+            y >= prcl->top  && y < prcl->bottom);
 }
 
 BOOL




More information about the Ros-diffs mailing list