[ros-diffs] [janderwald] 55090: [USBEHCI] - Don't acquire spinlock twice

[janderwald at svn.reactos.org]

Author: janderwald
Date: Mon Jan 23 03:50:11 2012
New Revision: 55090

URL: http://svn.reactos.org/svn/reactos?rev=55090&view=rev
Log:
[USBEHCI]
- Don't acquire spinlock twice

Modified:
    branches/usb-bringup-trunk/drivers/usb/usbehci_new/usb_queue.cpp

Modified: branches/usb-bringup-trunk/drivers/usb/usbehci_new/usb_queue.cpp
URL: http://svn.reactos.org/svn/reactos/branches/usb-bringup-trunk/drivers/usb/usbehci_new/usb_queue.cpp?rev=55090&r1=55089&r2=55090&view=diff
==============================================================================
--- branches/usb-bringup-trunk/drivers/usb/usbehci_new/usb_queue.cpp [iso-8859-1] (original)
+++ branches/usb-bringup-trunk/drivers/usb/usbehci_new/usb_queue.cpp [iso-8859-1] Mon Jan 23 03:50:11 2012
@@ -580,16 +580,18 @@
     //
     // now unlink the queue head
     // FIXME: implement chained queue heads
-    //
-
-    KeAcquireSpinLock(&m_Lock, &OldLevel);
-
+    // no need to acquire locks, as it is called with locks held
+    //
+
+    //
+    // unlink queue head
+    //
     UnlinkQueueHead(CurrentQH);
 
+    //
+    // insert into completed list
+    //
     InsertTailList(&m_CompletedRequestAsyncList, &CurrentQH->LinkedQueueHeads);
-
-    KeReleaseSpinLock(&m_Lock, OldLevel);
-
 }
 
 VOID