[ros-diffs] [cgutman] 55186: [USBHUB_NEW] - Remove the hacky way of determining if a device connect occurred (prone to all sorts of race conditions) and just always create a device since the only reason we res...

cgutman at svn.reactos.org cgutman at svn.reactos.org
Thu Jan 26 00:02:03 UTC 2012


Author: cgutman
Date: Thu Jan 26 00:02:03 2012
New Revision: 55186

URL: http://svn.reactos.org/svn/reactos?rev=55186&view=rev
Log:
[USBHUB_NEW]
- Remove the hacky way of determining if a device connect occurred (prone to all sorts of race conditions) and just always create a device since the only reason we reset right now is for a device connect

Modified:
    branches/usb-bringup-trunk/drivers/usb/usbhub_new/fdo.c

Modified: branches/usb-bringup-trunk/drivers/usb/usbhub_new/fdo.c
URL: http://svn.reactos.org/svn/reactos/branches/usb-bringup-trunk/drivers/usb/usbhub_new/fdo.c?rev=55186&r1=55185&r2=55186&view=diff
==============================================================================
--- branches/usb-bringup-trunk/drivers/usb/usbhub_new/fdo.c [iso-8859-1] (original)
+++ branches/usb-bringup-trunk/drivers/usb/usbhub_new/fdo.c [iso-8859-1] Thu Jan 26 00:02:03 2012
@@ -402,13 +402,9 @@
             }
 
             //
-            // Create the device object only if the port manipulation was started by a device connect
-            //
-            if (HubDeviceExtension->PortStatusChange[PortId-1].Status)
-            {
-                HubDeviceExtension->PortStatusChange[PortId-1].Status = 0;
-                Status = CreateUsbChildDeviceObject(DeviceObject, PortId, NULL);
-            }
+            // This is a new device
+            //
+            Status = CreateUsbChildDeviceObject(DeviceObject, PortId, NULL);
         }
     }
 




More information about the Ros-diffs mailing list