[ros-kernel] Bug 47 - white background in Explorer desktop window

[Martin Fuchs]

Hello Filip,

you wrote in the bug description:
> This is not our bug, but rather incompletness of Wine's shell32.dll.
> I did a small patch for this that was persent in my last Wine DLLs
> snapshot, but it wasn't completly correct.

What exactly was your patch in the last shell32 version?

I think this patch to Wine's shell32 solves the problem:

Index: shlview.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/shlview.c,v
retrieving revision 1.88
diff -u -p -d -r1.88 shlview.c
--- shlview.c   24 Oct 2003 04:23:37 -0000      1.88
+++ shlview.c   11 Nov 2003 21:13:11 -0000
@@ -1705,7 +1705,7 @@ static HRESULT WINAPI IShellView_fnCreat
          wc.hInstance          = shell32_hInstance;
          wc.hIcon              = 0;
          wc.hCursor            = LoadCursorA (0, (LPSTR)IDC_ARROW);
-         wc.hbrBackground      = (HBRUSH) (COLOR_WINDOW + 1);
+         wc.hbrBackground      = (HBRUSH) (lpfs->fFlags&FWF_DESKTOP? 0: (COLOR_WINDOW+1));
          wc.lpszMenuName       = NULL;
          wc.lpszClassName      = SV_CLASS_NAME;


It makes the shell view window of the desktop transparent if it is created with the flag FWF_DESKTOP (like it is in explorer).

I will post this patch to WineHQ. Perhaps it will be accepted, since it is a really small one. This last one I submitted (about SetShellWindowEx) is now in the queue for three weeks without any response.


Martin