[ros-kernel] new patch for a few things (some warning fixes plus
RLE support
Steven Edwards
steven_ed4153 at yahoo.com
Mon Nov 17 12:46:12 CET 2003
Hello Jon,
I will test/commit everything except #4 tonight. I dont have a linux
box with a mingw cross so I cant test it.
Thanks
Steven
--- Jonathan Wilson <jonwil at tpgi.com.au> wrote:
> This patch:
> 1.adds -Wall -Werror to drivers\dd\null (no other changs were needed)
> 2.adds -Werror to lib\zlib (various other flags were already present
> including -Wall)
> 3.makes all stuff under regtests build with -Wall -Werror
> 4.fixes the cross-compile problem posted here before
> 5.adds RLE support to ReactOS. This is implemented by uncompressing
> the
> bitmap in EngCreateBitmap and storing it as though it is uncompressed
> (i.e.
> changing the format to uncompressed). If it turns out later that we
> do need
> proper RLE support elsewhere, we can implement it. But for now, this
> should
> work (since when the driver gets handed back the bitmap, all they see
> is a
> regular uncompressed SURFOBJ)
>
> Can someone look at this and check it in?
> > Index: drivers/dd/null/makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/drivers/dd/null/makefile,v
> retrieving revision 1.17
> diff -u -w -r1.17 makefile
> --- drivers/dd/null/makefile 16 Nov 2003 22:42:43 -0000 1.17
> +++ drivers/dd/null/makefile 17 Nov 2003 02:41:26 -0000
> @@ -8,7 +8,7 @@
>
> TARGET_OBJECTS = null.o
>
> -TARGET_CFLAGS = -D__USE_W32API
> +TARGET_CFLAGS = -D__USE_W32API -Wall -Werror
>
> #TARGET_LFLAGS = -Wl,--file-alignment,0x20
> -Wl,--section-alignment,0x20
>
> Index: lib/zlib/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/lib/zlib/Makefile,v
> retrieving revision 1.5
> diff -u -w -r1.5 Makefile
> --- lib/zlib/Makefile 7 Aug 2003 04:03:24 -0000 1.5
> +++ lib/zlib/Makefile 17 Nov 2003 02:42:55 -0000
> @@ -8,7 +8,7 @@
>
> TARGET_CFLAGS = \
> -MMD -O3 -Wall -Wwrite-strings -Wpointer-arith -Wconversion \
> - -Wstrict-prototypes -Wmissing-prototypes
> + -Wstrict-prototypes -Wmissing-prototypes -Werror
>
> # require os code to explicitly request A/W version of
> structs/functions
> TARGET_CFLAGS += -D_DISABLE_TIDENTS
> Index: regtests/kmregtests/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/kmregtests/Makefile,v
> retrieving revision 1.1
> diff -u -w -r1.1 Makefile
> --- regtests/kmregtests/Makefile 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/kmregtests/Makefile 17 Nov 2003 02:43:00 -0000
> @@ -10,7 +10,7 @@
>
> TARGET_LIBS = $(SDK_PATH_LIB)/rtshared.a
>
> -TARGET_CFLAGS = -I../shared
> +TARGET_CFLAGS = -I../shared -Werror -Wall
>
> TARGET_GENREGTESTS = yes
>
> Index: regtests/kmregtests/driver.c
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/kmregtests/driver.c,v
> retrieving revision 1.1
> diff -u -w -r1.1 driver.c
> --- regtests/kmregtests/driver.c 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/kmregtests/driver.c 17 Nov 2003 02:43:01 -0000
> @@ -149,7 +149,6 @@
> {
> PDEVICE_OBJECT DeviceObject;
> UNICODE_STRING DeviceName;
> - UNICODE_STRING DosName;
> NTSTATUS Status;
>
> /* Register driver routines */
> Index: regtests/kmrtint/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/kmrtint/Makefile,v
> retrieving revision 1.1
> diff -u -w -r1.1 Makefile
> --- regtests/kmrtint/Makefile 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/kmrtint/Makefile 17 Nov 2003 02:43:01 -0000
> @@ -10,7 +10,7 @@
>
> TARGET_SDKLIBS = ntdll.a kernel32.a
>
> -TARGET_CFLAGS = -I../shared -I../kmregtests
> +TARGET_CFLAGS = -I../shared -I../kmregtests -Werror -Wall
>
> TARGET_BASE = 0x50000000
>
> Index: regtests/regtests/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/regtests/Makefile,v
> retrieving revision 1.1
> diff -u -w -r1.1 Makefile
> --- regtests/regtests/Makefile 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/regtests/Makefile 17 Nov 2003 02:43:01 -0000
> @@ -12,7 +12,7 @@
>
> TARGET_SDKLIBS = rtshared.a ntdll.a kernel32.a
>
> -TARGET_CFLAGS = -I../shared
> +TARGET_CFLAGS = -I../shared -Wall -Werror
>
> TARGET_OBJECTS = \
> regtests.o
> Index: regtests/shared/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/shared/Makefile,v
> retrieving revision 1.1
> diff -u -w -r1.1 Makefile
> --- regtests/shared/Makefile 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/shared/Makefile 17 Nov 2003 02:43:01 -0000
> @@ -8,6 +8,8 @@
>
> TARGET_NAME = rtshared
>
> +TARGET_CFLAGS = -Wall -Werror
> +
> TARGET_OBJECTS = \
> regtests.o
>
> Index: regtests/shared/regtests.c
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/shared/regtests.c,v
> retrieving revision 1.1
> diff -u -w -r1.1 regtests.c
> --- regtests/shared/regtests.c 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/shared/regtests.c 17 Nov 2003 02:43:02 -0000
> @@ -10,6 +10,7 @@
> #define NTOS_MODE_USER
> #include <ntos.h>
> #include "regtests.h"
> +#include <string.h>
>
> #define NDEBUG
> #include <debug.h>
> Index: regtests/win32base/Makefile
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/win32base/Makefile,v
> retrieving revision 1.1
> diff -u -w -r1.1 Makefile
> --- regtests/win32base/Makefile 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/win32base/Makefile 17 Nov 2003 02:43:02 -0000
> @@ -10,7 +10,7 @@
>
> TARGET_SDKLIBS = rtshared.a ntdll.a kernel32.a
>
> -TARGET_CFLAGS = -I../shared
> +TARGET_CFLAGS = -I../shared -Wall -Werror
>
> TARGET_BASE = 0x60000000
>
> Index: regtests/win32base/file-1.c
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/regtests/win32base/file-1.c,v
> retrieving revision 1.1
> diff -u -w -r1.1 file-1.c
> --- regtests/win32base/file-1.c 11 Jul 2003 18:13:57 -0000 1.1
> +++ regtests/win32base/file-1.c 17 Nov 2003 02:43:02 -0000
> @@ -1,6 +1,7 @@
> #include <windows.h>
> #include <stdlib.h>
> #include <stdio.h>
> +#include <string.h>
>
> #include "regtests.h"
>
> @@ -21,7 +22,7 @@
>
> if (file == INVALID_HANDLE_VALUE)
> {
> - sprintf(Buffer, "Error opening file (Status %x)",
> GetLastError());
> + sprintf(Buffer, "Error opening file (Status %lx)",
> GetLastError());
> return TS_FAILED;
> }
>
> @@ -30,7 +31,7 @@
>
> if (WriteFile( file, buffer, 4096, &wrote, NULL) == FALSE)
> {
> - sprintf(Buffer, "Error writing file (Status %x)",
> GetLastError());
> + sprintf(Buffer, "Error writing file (Status %lx)",
> GetLastError());
> return TS_FAILED;
> }
>
> @@ -38,7 +39,7 @@
>
> if (ReadFile( file, buffer, 4096, &wrote, NULL) == FALSE)
> {
> - sprintf(Buffer, "Error reading file (Status %x)",
> GetLastError());
> + sprintf(Buffer, "Error reading file (Status %lx)",
> GetLastError());
> return TS_FAILED;
> }
> for (c = 0; c < sizeof(buffer); c++)
> Index: subsys/win32k/eng/surface.c
> ===================================================================
> RCS file: /CVS/ReactOS/reactos/subsys/win32k/eng/surface.c,v
> retrieving revision 1.26
> diff -u -w -r1.26 surface.c
> --- subsys/win32k/eng/surface.c 30 Oct 2003 08:56:38 -0000 1.26
> +++ subsys/win32k/eng/surface.c 17 Nov 2003 02:43:11 -0000
> @@ -43,6 +43,13 @@
> #define NDEBUG
>
=== message truncated ===>
_______________________________________________
> Ros-kernel mailing list
> Ros-kernel at reactos.com
> http://reactos.geldorp.nl:8080/mailman/listinfo/ros-kernel
__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree
More information about the Ros-kernel
mailing list