[Fwd: RE: [ros-kernel] Hunting a task]

[Thomas Weidenmueller]

Vizzini wrote:

>Skywing cannot post atm so this is from him.
>
>-----Forwarded Message-----
>From: Skywing <skywing at valhallalegends.com>
>To: Vizzini <vizzini at plasmic.com>
>Subject: RE: [ros-kernel] Hunting a task
>Date: Tue, 21 Oct 2003 14:30:39 -0500
>
>I myself have written code that will break if MessageBox is not implemented
>with dialog boxes.  I've seen discussion on the Microsoft programming
>newsgroups where other people have done the same thing, too.  Furthermore,
>the Platform SDK even says that MessageBox uses dialog boxes.
>
>"lpCaption
>[in] Pointer to a null-terminated string that contains the dialog box title.
>If this parameter is NULL, the default title Error is used. 
>uType
>[in] Specifies the contents and behavior of the dialog box. This parameter
>can be a combination of flags from the following groups of flags." -
>MessageBox documentation.
>
>Also, the MessageBox family of functions is organized under the "Dialog
>Boxes" section in the Platform SDK.
>
>All of these factors lead me to believe that changing this behavior is
>dangerous and will break compatibility.
>
>Note that creating dialog boxes with dynamic control sets/positions is
>possible through using DialogBoxIndirectParam/CreateDialogBoxIndirectParam
>and modifying the dialog template before using it to create the dialog.  I
>believe that this is in fact what the Microsoft implementation of MessageBox
>does.
>  
>
That's the latest implementation of MessageBoxes in ReactOS, except that 
ansi messages for some reason don't work (Small bug i believe)

>-----Original Message-----
>From: ros-kernel-bounces at reactos.com [mailto:ros-kernel-bounces at reactos.com]
>On Behalf Of Waldo Alvarez Cañizares - another buried alive
>Sent: Tuesday, October 21, 2003 10:07 AM
>To: ReactOS Kernel List
>Subject: Re: [ros-kernel] Hunting a task
>
>Hi ppl:
> 
>  
>
>>>- Get ansi MessageBox working (user32.dll)
>>>      
>>>
>>Seems easier. I think i can handle this, but i will only do it if nobody 
>>is working there.
>>
>>    
>>
>
>  
>
go ahead ;)

>I was taking a look to MessageBox. Seems to me that it is quite complete 
>with some small things to do. But i saw that a messagebox is implemented 
>as a dialog. This seems incorrect to me.
>
>1- The window size for it is unknown when you create it (depends on 
>factors as the text lenght)
>
>2- You don't know the buttons it contains until you create it.
>
>3- You don't know if it has an icon until you create it. (current 
>implementation will contain a dummy static control)
>  
>
The latest implementation calculates everything before actually passing 
the dialog template with it's control to DialogBoxIndirectParam()

>4- And the worst. What if the system is unable to load resources and you 
>want to display an error using a messagebox?
>  
>
I doubt windows can even handle this case, I mean win32k needs memory, 
etc...

>So actually you almost don't know anything until it is created.
>
>That's why I think that everything should be created when the function is 
>called. Somebody against it. If you do please explain. Because I'm about 
>to change it.
>  
>
I agree, already done :)

>Best Regards
>Waldo
>
>_______________________________________________
>Ros-kernel mailing list
>Ros-kernel at reactos.com
>http://reactos.geldorp.nl:8080/mailman/listinfo/ros-kernel
>
>
>
>_______________________________________________
>Ros-kernel mailing list
>Ros-kernel at reactos.com
>http://reactos.geldorp.nl:8080/mailman/listinfo/ros-kernel
>
>
>  
>