[ros-kernel] Commits to subsys/win32k

[Mike Nordell]

Thomas Weidenmueller wrote:

> Some of you may already know, I've been working on a win32k redesign...
[snip]
> - My new design eliminates all user object handles (not yet GDI handles)
> from the internal structures and functions,

I quoted the above as an addition to the implications of my immediate
question, below.

> - There are now global locks (ntuser/userlock.c) for user mode objects
> to avoid thousands of lockings all the time. These global locks are
> going to be  per window-station instead of session-wide.

Have you considered how this will affect SMP systems?

OK, maybe this global (per-winsta is in effect global, from a users POV)
lock for user, but I'm confident something similar will not be appropriate
when it comes to GDI.

I'd appreciate some elaboration on the considerations taken that led to the
conclusion this was the way to go. At first glance it seems this approach,
paired with the unock/callback/lock idiom can create a few problems - what
if a thread on CPU0 is doing unluck(butterfingers, but I left it misspelled
since it became quite appropriate) in preparation to do a callback, but then
CPU1 gets the global lock and e.g. closes the window?

/Mike