[ros-kernel] RE: [ros-cvs] CVS Update: reactos

[Hartmut Birr]

Hi,

I think some of the changes are not correct:

diff -u -r1.1 -r1.2
--- tuiconsole.c        11 Jan 2004 17:31:16 -0000      1.1
+++ tuiconsole.c        20 Jul 2004 11:06:47 -0000      1.2
@@ -1,4 +1,4 @@
-/* $Id: tuiconsole.c,v 1.1 2004/01/11 17:31:16 gvg Exp $
+/* $Id: tuiconsole.c,v 1.2 2004/07/20 11:06:47 navaraf Exp $
  *
  * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
@@ -113,7 +113,7 @@
   TuiCopyRect((char *) (ConsoleDraw + 1), Buff, Region);

   if (! DeviceIoControl(ConsoleDeviceHandle, IOCTL_CONSOLE_DRAW,
-                        ConsoleDraw, ConsoleDrawSize, NULL, 0,
&BytesReturned, NULL))
+                        NULL, 0, ConsoleDraw, ConsoleDrawSize,
&BytesReturned, NULL))
     {
       DPRINT1("Failed to draw console\n");
       HeapFree(Win32CsrApiHeap, 0, ConsoleDraw);
@@ -307,7 +307,7 @@
       /* redraw the console to clear off old title */
       ConioDrawConsole(ActiveConsole);
       if (! DeviceIoControl(ConsoleDeviceHandle,
IOCTL_CONSOLE_WRITE_OUTPUT_CHARACTER,
-                            Buffer, sizeof(COORD) + Title.Length, NULL, 0,
+                            NULL, 0, Buffer, sizeof(COORD) + Title.Length,
                             &BytesReturned, NULL))
         {
           DPRINT1( "Error writing to console\n" );

In both calls to DeviceIoControl, the datas are send to the device. This
means we must use the input buffer and not the output buffer. Input and
output is the meaning for the device and not for the caller.

- Hartmut

> -----Original Message-----
> From: ros-cvs-bounces at reactos.com 
> [mailto:ros-cvs-bounces at reactos.com] On Behalf Of 
> navaraf at osexperts.com
> Sent: Tuesday, July 20, 2004 4:07 AM
> To: ros-cvs at reactos.com
> Subject: [ros-cvs] CVS Update: reactos
> 
> 
> CVSROOT:	/CVS/ReactOS
> Module name:	reactos
> Repository:	reactos/subsys/csrss/win32csr/
> Changes by:	navaraf at mok.osexperts.com	04/07/20 04:06:48
> 
> Modified files:
> 	reactos/drivers/dd/blue/: blue.c 
> 	reactos/ntoskrnl/io/: buildirp.c cleanup.c 
> 	reactos/subsys/csrss/win32csr/: tuiconsole.c 
> 
> Log message:
> 	- Fix handling of METHOD_IN_DIRECT IRPs.
> 
> _______________________________________________
> Ros-cvs mailing list
> Ros-cvs at reactos.com
> http://reactos.com/mailman/listinfo/ros-cvs
>