[ros-kernel] Re: [ros-cvs] CVS Update: reactos

[Eric Kohl]

"Filip Navara" <xnavara at volny.cz> wrote:


> 1) Why don't you use IoQueryDeviceDescription for querying the
information?

I plan to use IoQueryDeviceDescription but IMO it is not ready for use yet.
The current implementation got a few weak spots, like calls to system
functions (NtQueryValueKey or ExAllocatePool) with missing return value
checks or the use of absolute registry paths.


> 2) We need to port the detection algorithm from sermouse to freeldr. It
> has been drastically changed since it was copied to freeldr last time.

That's not a good idea. FreeLoader checks the presence of a serial pointing
device (mouse) and tries to read its PnP-ID but it does not try to determine
the mouse protocol. That's up to sermouse.

Btw, the patch to sermouse is only a small piece of a larger work to enable
the user to select and install a mouse driver as part of the first stage
setup. Of course autodetection will be supported.


Regards,
Eric