[ros-kernel] System DLL image bases in debug builds

[Mike Nordell]

Hartmut Birr wrote:

> I've changed my local source tree a little bit. The definitions of all dll
> base adresses are now in baseaddress.cfg. This is what Mike has described.

There were a few things I hadn't considered, and some I didn't even mention
since I didn't anticipate the idea to gain foothold this fast. :-)

What I envisioned was that this config file would be sorted in
image-base-address order, to allow human readers to quickly find a specific
address.

I believe the placement of it would be reactos/lib, to display "I only
affect these libraries". Placed at top-level it more gives the impression of
affecting all of ReactOS.

Unless there is a makefile included only by system-libraries makefiles, I
think this config file should only be included by the libraries makefiles
themselves - or create a makefile (helper-lib.mk?) for this purpose, to only
affect just the system libraries. Building anything but those libraries it
simply makes no sense to include this address-space configuration file.

I completely forgot about the matter that the DLLs would have to have this
config file as a dependant, requiring even further additions to the
libraries makefiles. To use kernel32.dll as an example. Where it today
probably has something like:
  kernel32.dll : KERNEL32_OBJS ...
    ld ...
it would have to be modified to
  kernel32.dll : image_bases_config_file KERNEL32_OBJS ...
    ld ...

Does any of this make any sense? Did I miss something? Are there reasons for
not locating and localizing this as close as possible to the libraries, and
only affecting them, that I haven't considered?


/Mike