[ros-kernel] Questions about recent commits to code in User32/Win32k/Gdi

[Steven Edwards]

Hello,
I dont want anyone to take offence at this but this was raised by a
friend that does quite a lot of work on WINEs user32 implementation. I
have to ask these questions as I could put the company I am now working
for in trouble if I touch code in ReactOS that might be "tainted" and
then work on Wine code that could make it in to CrossOver.

anonymous: I watching for weiden's commits to the reactos cvs tree. He
is mainly working on user32 and gdi32.

anonymous: for instance his CreateWindowEx code has many small
differences with Wine code:
if(!(WindowObject->Style & (WS_POPUP | WS_CHILD)))
{
 /* clip siblings for overlapped windows. */
 WindowObject->Style |= (WS_CAPTION | WS_BORDER | WS_CLIPSIBLINGS);
}

anonymous: Wine does not have his. And I don't see how any real app
could depend on it, therefore it can't be a simple bug fix

anonymous: one of his gdi patches blatantly claims that Wine's code for
FrameRect is wrong. How did he find it? How that could effect real word
applications?

anonymous: FrameRect -> FrameRgn


I am not trying to accuse anyone of anything, its just we have to be
careful of our sources even more so now that the Windows source code
has leaked. Could we see a regression test or some documentation that
shows how these changes are more "correct"?

Thanks
Steven



	
		
__________________________________
Do you Yahoo!?
Win a $20,000 Career Makeover at Yahoo! HotJobs  
http://hotjobs.sweepstakes.yahoo.com/careermakeover