[ros-dev] Re: [ros-diffs] [royce] 17819: msvc6 compatibility and small performance improvement in filename completion

[Hartmut Birr]

royce at svn.reactos.com wrote:

>msvc6 compatibility and small performance improvement in filename completion
>
>Modified: trunk/reactos/subsys/system/cmd/internal.c
>  
>
> *Modified: trunk/reactos/subsys/system/cmd/internal.c*
>
>--- trunk/reactos/subsys/system/cmd/internal.c	2005-09-12 14:55:55 UTC (rev 17818)
>+++ trunk/reactos/subsys/system/cmd/internal.c	2005-09-12 16:06:53 UTC (rev 17819)
>@@ -276,7 +276,7 @@
>
> 	TCHAR * tmpPath;
> 	TCHAR szCurrent[MAX_PATH];
> 	TCHAR szMsg[RC_STRING_MAX_SIZE];
>  
>
>-	INT i;
>  
>
>+	UINT i;
>  
>
>  
>  
> 	/* Filter out special cases first */
>  
>
> ------------------------------------------------------------------------

If you change a variable from signed to unsigned, you have to check for
comparing with zero or negativ values like this:

        /* Strip the paths back to the folder they are in */
        for(i = (_tcslen(szFinalPath) -  1); i > -1; i--)

- Hartmut