[ros-dev] TR: [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

[Hermès BÉLUSCA - MAÏTO]

(Message resent because the other one was automatically rejected because it was too large).

-----Message d'origine-----
De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Hermès BÉLUSCA - MAÏTO
Envoyé : mercredi 2 mars 2016 10:14
À : 'ReactOS Development List'
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

Thanks Pierre for your ideas. I will modify the message box to try to integrate those options.
At the moment we are (in usetup) limited, so repairing the errors will be done later. The rest can be implemented easily.
The fact is that the only error that happens as soon as you write files using ReactOS' fastfat driver is that fastfat doesn't update the "free cluster number" field in the FSInfo sector of FAT32 disk.
Because of that, each time you try to reinstall ReactOS without formatting on such a partition, you get the checkdisk complaining that this number is wrong & needs to be corrected, but then the VfatChkdsk returns a non-success error that is interpreted by Usetup as a failure (and the error message appears, forbidding the user to continue nevertheless to install ROS).

Cheers,
Hermès

-----Message d'origine-----
De : Ros-dev [mailto:ros-dev-bounces at reactos.org] De la part de Pierre Schweitzer Envoyé : mercredi 2 mars 2016 08:47 À : ros-dev at reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

No?!
This is totally broken and is to be reverted.

If you detect errors, there are only 3 issues:
- Offer the user to attempt to repair errors
- Offer the user to format
- Exit (as it was done previously)

(If repairing fails, you fall into the two next cases).
You cannot ignore errors and let the use write on a borked file system.