[ros-dev] Regression in r75772 broke multiple disk drive support

[Dimitrij Klingbeil]

Hi all,

It looks like revision 75772 (removed a "DeviceExt->OpenHandleCount--;")
has introduced some significant unintended consequences.
Ever since I can't get ReactOS to recognize a second hard drive.

My configuration is like this:
- ReactOS in a VirtualBox VM, VirtualBox version 5.11.18
- VM configured for Windows 2003 32-bit, with 1 CPU
- Emulated Chipset: PIIX3, no USB, no Audio, no Serial
- AMD-V active, Nested Paging active,
- No paravirtualization interface, no guest additions
- Emulated Storage: SATA controller with 4 ports
  - Port 0: First Hard disk (has partition C)
  - Port 1: Second Hard disk (has partition D)
  - Port 3: CDROM (to install ReactOS from, E)
- Each hard disk has one single primary partition (FAT formatted by an older
ReactOS setup)
- On C I install ReactOS (re-formatting the partition in the process)
- On D there is some data (a small collection of program installers to try
out)

Now, inside ReactOS I cannot see the contents of D. The drive itself shows
up, but unformatted and of a zero size. In the revisions before 75772 there
were no problems, I could see the drive and use the data on it.
Re-installing r75771 shows that the drive image is OK and the data is still
there, so it's not the data that was corrupted.

If I insert a CDROM image (with ReactOS already running), the CDROM drive
(E) suddently disappears and D now has the CDROM in it (so happened just now
with r75872). When I eject the CDROM, D becomes empty but still shows the
icon for a CDROM. E does not re-appear.

75772 looks like a very small change, but something must have gone really
off the rails...

Regards,
Dimitrij



P.S. This was at first sent from the wrong (not subscribed to the list)
address by mistake. I think the first one was rejected by the list SW,
but sorry if the message appears twice.