Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Fri Oct 24, 2014 11:43 am

vicmarcal wrote:Maybe PeaZip and Lazarus won't show their icons flipped? Homework for anyone interested around ;)
Unfortunately they're still upside down on r64947.
The icons also got a bit worse on 16-bit depth in some cases - Rapps has black parts of icons (r64947, r64915) - maybe it's this CORE-8695

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Tue Nov 18, 2014 11:57 am

I nominate Eric Kohl (ekohl) for a retroactive Fix of the Week for the week of September 28 through October 4, 2014. His partition code rewrite committed in several revisions from r63355 to r64487 (last commit on October 3, 2014) has resolved these bugs:
  • CORE-4261 - USetup damages partition table (over 5 years old!)
  • CORE-5206 - Setup fails with typical Linux Partition Table
  • CORE-5673 - ReactOS setup generates corrupted FAT filesystem

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Sun Dec 14, 2014 2:19 pm

r65635 by Cameron Gutman:
[CDFS]
- Fix CD-ROM disc change handling
- Fixes CORE-6119
This fixes a bug that was quite a pain for last 3.5 years, great news!

Jedi-to-be
Posts: 691
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: Fix of the Week

Post by Jedi-to-be » Fri Dec 26, 2014 2:07 pm

hpoussin 65833 changed 2 files trunk in reactos
[FREELDR] Support custom SystemPath and ramdisk in setup phase
We can now start ReactOS installation via PXE boot.
Options
-2+2 /trunk/reactos/boot/freeldr/freeldr/inffile/inffile.c
-10+65 /trunk/reactos/boot/freeldr/freeldr/windows/setupldr.c
https://code.reactos.org/changelog/reactos?cs=65833

Julcar
Posts: 88
Joined: Thu Jul 31, 2008 8:19 pm

Re: Fix of the Week

Post by Julcar » Mon Feb 02, 2015 3:35 am

rev 66094 fixes CORE-7821 which makes reactos usable at the most of Intel 810 chipsets

Jedi-to-be
Posts: 691
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: Fix of the Week

Post by Jedi-to-be » Thu Feb 05, 2015 2:05 pm

Timo Kreuzer and his epic fixes of freeloader memory issues
66087 changed 14 files trunk
[FREELDR]
Make the DiskReadBuffer location and size dynamic. Should fix a number of issues with non-standard BIOSes. Many thanks to jeditobe for his help with testing/debugging of this issue.
CORE-8899 #resolve
CORE-9031 #resolve

66091
[FREELDR]
Fix/improve range check.
CORE-8995 #resolve
CORE-8997 #resolve


66099 changed 1 file trunk
[FREELDR]
Increase number of static memory descriptors from 32 to 40.
CORE-9097 #resolve #comment Please retest and reopen if it's still not fixed.
Last edited by Jedi-to-be on Thu Feb 05, 2015 2:11 pm, edited 1 time in total.

Jedi-to-be
Posts: 691
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: Fix of the Week

Post by Jedi-to-be » Thu Feb 05, 2015 2:08 pm

Hermes Belusca-Maito and his continuous effort of improving freeloader abilities

https://code.reactos.org/changelog/reac ... t/freeldr/
66051 changed 6 files trunk
[REACTOS]
Add basic Hybrid-CD generation to our build system.
Few changes were needed, especially in how we deal with the CD target "all": it's only for all the CD targets *BUT* the hybridcd. For the hybridcd you need to always specify the target manually (like in "... FOR all hybridcd" or "... FOR bootcd hybridcd" for example).
Since at the moment we cannot have the bootcd in RAMDISK, and I want to be able to either have the hybridcd booting livecd from within the CD (i.e. read/writes from the CD) or in RAMDISK, I need to also add the files that are going to be copied into the bootcd or livecd into the hybridcd.
CORE-9069 #resolve

Jedi-to-be
Posts: 691
Joined: Sun Mar 16, 2008 11:26 am
Location: Russia, Stavropol
Contact:

Re: Fix of the Week

Post by Jedi-to-be » Sat Feb 21, 2015 11:19 pm

Thomas Faber
More66394 changed 28 files trunk in reactos
[DESK.CPL]
- Load wallpapers using GDI+ and convert them to bitmap format as needed. We now support PNG and JPEG (and more) wallpapers! Patch by Ricardo Hanke, small modifications by me.
CORE-8802 #resolve

https://code.reactos.org/changelog/reactos?cs=66394

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Sun Feb 22, 2015 9:42 am

Many thanks to all the devs who work on ReactOS.

Also, thank you Jedi-to-be for pointing out some especially notable fixes as Fix of the Week. I enjoy learning about them.

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Thu May 28, 2015 10:24 am

I nominate the work of aandrejevic and others on the Fast486 FPU for Fix of the Week.

aandrejevic's log message for revision 67934 is, "Now that the Fast486 FPU is feature-complete, tell programs that we have a built in FPU. (This commit may cause regressions if there are bugs in the FPU.)"

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Thu Jun 11, 2015 9:20 pm

Though it's not a commit into SVN, I nominate Pierre Schweitzer's efforts:
mailing list wrote:We are now running Jira 6 in production
JIRA 6 is great! :-)

gonzoMD
Posts: 991
Joined: Fri Oct 20, 2006 7:49 am
Location: Germany
Contact:

Re: Fix of the Week

Post by gonzoMD » Wed Jun 17, 2015 10:05 pm

Finally <3
[SHELL32] Report file system changes in SHChangeNotifyRegister. Brought to you by Huw Campbell. CORE-1171

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Fix of the Week

Post by Pi_User5 » Thu Jun 18, 2015 1:07 am

Finally <3
Have you gotten it to work? I haven't.
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Sat Sep 05, 2015 7:56 pm

This is not about a certain fix, but about a week. In this week we have already seen over -150-160 commits by ROS devs, which is awesome! Depending on your definition of week and your timezone, there may be up to a day and a half left :-)

vicmarcal
Test Team
Posts: 2732
Joined: Mon Jul 07, 2008 12:35 pm

Re: Fix of the Week

Post by vicmarcal » Fri Sep 11, 2015 8:15 pm

Too many commits which deserves the Fix of the Week, but since I am an "user" guy, I would say:

James Tabor for his Layered support commit, which will make a lot of apps which uses layered windows really happy.
It is just a green commit but more work is hopefully following. There are a lot of "this window is not shown when clicked here or launched" bugreports in Jira and most are due "unsupported layered windows". So expect some bugs being fixed...

The ReactOS Rocking Week hasnt ended. All started with a HackFest.
Image

Post Reply

Who is online

Users browsing this forum: No registered users and 38 guests