Fix of the Week

Here you can discuss ReactOS related topics.

Moderator: Moderator Team

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Fix of the Week

Post by Pi_User5 » Wed Dec 16, 2015 12:35 am

Revision 70350:
[WINSRV] Do not kill system processes when a user is logging off. Fixes user logoff. #CORE-2391 #resolve
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

Pi_User5
Posts: 752
Joined: Thu May 01, 2014 4:18 am
Location: United States

Re: Fix of the Week

Post by Pi_User5 » Wed Jan 27, 2016 9:07 pm

70646 by Aleksey Bragin
[LDR]
- Fix a typo in kernel32's manifest prober routine
- Don't RtlGetActiveActivationContext if it's already existing
- Improve actctx and ldr debug prints
- This fixes numerous LDR bugs, such as the famous bug with MSVCR90 CORE-7313, .NET installation issues CORE-7489 and, hopefully, many other. Thank you very much for putting your trust in me
I use ReactOS on real hardware. Will you? My Computers: https://www.reactos.org/wiki/PC_ROS_Rigs Go all the way to the bottom.

Image

ctasan
Posts: 355
Joined: Mon Feb 24, 2014 7:02 pm
Location: Istanbul, Turkey

Re: Fix of the Week

Post by ctasan » Fri Jan 29, 2016 1:21 pm

Pi_User5 wrote:70646 by Aleksey Bragin
[LDR]
- Fix a typo in kernel32's manifest prober routine
- Don't RtlGetActiveActivationContext if it's already existing
- Improve actctx and ldr debug prints
- This fixes numerous LDR bugs, such as the famous bug with MSVCR90 CORE-7313, .NET installation issues CORE-7489 and, hopefully, many other. Thank you very much for putting your trust in me
This commit led some regressions, though.

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Sun May 08, 2016 1:14 am

I nominate pschweitzer's r71270 for Fix of the Week. This fix resolved CORE-3875, a bug affecting FASTFAT. The log message says:
In case we're performing an in-place move (ie, in the same directory), if short name matches before and after, keep it.

This avoids that a file with long file name sees its short name changing on normally 'non-effect' renames.
For instance, in case of case-change only rename, short name will now be preserved.

See ya, you 7y old bug : - )

Black_Fox
Posts: 1584
Joined: Fri Feb 15, 2008 9:44 pm
Location: Czechia

Re: Fix of the Week

Post by Black_Fox » Thu Jul 28, 2016 10:15 am

r72030 adds the ability to mouse scroll the console window:
[CONSRV]
- Do not hardcode the values of some flags used with GetKeyState.
- Rework a bit the 'OnScroll' function.
- Implement mouse scrolling the console.
CORE-9900 #resolve
CORE-8394
- In mouse selection mode, allow the user to enlarge the current selection area by pressing the SHIFT key together with clicking on some point.

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Thu Sep 01, 2016 12:16 pm

I nominate r72521 for Fix of the Week. CORE-1578 is a 10-year old bug. A patch by Sebastian Gasiorek was committed by Jim Tabor.

Log Message:
[NtGDI]
- Patch by Sebastian Gasiorek : Fix incorrect placement of the text in the Tab buttons.
Implement TA_UPDATECP.
See CORE-1578 and CORE-11415.
Last edited by middings on Wed Sep 21, 2016 11:49 am, edited 1 time in total.

EmuandCo
Developer
Posts: 4156
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Fix of the Week

Post by EmuandCo » Wed Sep 21, 2016 1:10 am

r72750 committed by AmineKhaldi:

[WS2_32] The current ws2_32 served us well, but it's time for ws2_32_new to shine. It took slightly more than 7 years since Ged brought-in Alex' impressive work on this module, and thanks to the great follow-up work by Peter Hater, Andreas Maier, Thomas Faber and everyone else involved in the effort, we now have a chance to retire ws2_32 in favor of ws2_32_new. The test results speak for the excellent achievements, and this serves as a platform to continue inspecting and fixing the remaining test failures. Thank you all for a job well done! Please see CORE-10440 for a summary of the changes performed in this commit.

HELLO PROPER WINSOCK :D
Image
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

middings
Posts: 916
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Fix of the Week

Post by middings » Sat Oct 22, 2016 6:00 am

revision 72867 is my nomination for Fix of the Week during the week of 25 September through 1 October 2016. A patch by Peter Hater was committed by Amine Khaldi. This patch improved DNS facilities in ReactOS and resolved 3-year old bug CORE-7441 and CORE-11394. These bugs affected browser programs.

The log message says:
[ADNS] [DNSAPI] [MSWSOCK] Several fixes and improvements to DnsQuery and co, detailed in CORE-11394. This also fixes CORE-7441, many tests in dnsapi:DnsQuery, ws2_32:getaddrinfo and more. Brought to you by Peter Hater.
Honorable mention goes to all the testers and developers who contributed to identifying the problem, investigating its cause, and testing its proposed fixes.

hbelusca
Developer
Posts: 1009
Joined: Sat Dec 26, 2009 10:36 pm
Location: Zagreb, Croatia

Re: Fix of the Week

Post by hbelusca » Wed Oct 26, 2016 4:12 pm

I nominate revision 73039 (and the subsequent commits r73040 and 73041) as: The Commit of The Month!!
Revision 73039
Author: cfinck
Date: Wed Oct 26 12:37:27 2016 UTC
Log Message:

[PRINTING]
Finally merge my branch "colins-printing-for-freedom", giving us an initial implementation of a Win32-compatible Printing Stack (localmon, localspl, spoolss, spoolsv, winspool)
You can now send raw data to parallel port printers using documented Win32 API. An example application is in my "winspool_print" commandline tool merged to rosapps.
ReactOS folks, thanks for your support during the development of this, making my bachelor's thesis a reality! :)

Documentation/Thesis: https://svn.reactos.org/reactos/trunk/d ... thesis.pdf
Video: https://www.youtube.com/watch?v=cNzePucTOLY

CORE-10489

EmuandCo
Developer
Posts: 4156
Joined: Sun Nov 28, 2004 7:52 pm
Location: Germany, Bavaria, Steinfeld
Contact:

Re: Fix of the Week

Post by EmuandCo » Wed Oct 26, 2016 5:01 pm

/me wets himself
Image
ReactOS is still in alpha stage, meaning it is not feature-complete and is recommended only for evaluation and testing purposes.

ROCKNROLLKID
Posts: 255
Joined: Mon Oct 17, 2016 3:19 am
Contact:

Re: Fix of the Week

Post by ROCKNROLLKID » Wed Dec 07, 2016 3:18 am

I think this deserves fix of the week. Ultimately, it is part 2 of getting Word 2010 fixed. Congrats to hbelusca. https://jira.reactos.org/browse/CORE-12414

ROCKNROLLKID
Posts: 255
Joined: Mon Oct 17, 2016 3:19 am
Contact:

Re: Fix of the Week

Post by ROCKNROLLKID » Fri Dec 23, 2016 12:37 am

I nominate Jimtabor for fixing this almost 10 year old bug: https://jira.reactos.org/browse/CORE-2201

manuel
Posts: 401
Joined: Thu Jan 28, 2010 11:20 pm
Location: México
Contact:

Re: Fix of the Week

Post by manuel » Sat Dec 24, 2016 3:53 am

was fixed this bug?

ROCKNROLLKID
Posts: 255
Joined: Mon Oct 17, 2016 3:19 am
Contact:

Re: Fix of the Week

Post by ROCKNROLLKID » Sun Dec 25, 2016 4:57 am

manuel wrote:
was fixed this bug?
Yes, revision 73475 included the fix.

milon
Posts: 966
Joined: Sat Sep 05, 2009 9:26 pm

Re: Fix of the Week

Post by milon » Wed Jan 25, 2017 5:28 pm

I nominate both of cfinck's recent commits for fix of the week/month! Hybrid live/install is on the way!!

https://svn.reactos.org/svn/reactos?vie ... sion=73594
r73594 wrote: Author: cfinck
Date: Tue Jan 24 22:45:37 2017 UTC (16 hours, 39 minutes ago)
Log Message:
[BOOTSECT]
Overhaul our ISO boot sector:
- Add another entry point for hybrid booting (called by isombr) and the hybrid signature needed for isohybrid.
- Import latest isolinux.asm "API" from http://repo.or.cz/syslinux.git/blob/8bb ... olinux.asm (latest version to date) and http://repo.or.cz/syslinux.git/blob/914 ... olinux.asm (latest version that came with all functions in ASM).
Among other things, this brings us getlinsec_ebios (for reading setupldr.sys in hybrid/MBR mode) and BrokenAwardHack (for working around broken Award BIOSes)
- Fix upstream getlinsec_ebios to load files >64K.
- Load the HDD boot sector directly to 0x7C00 instead of trackbuf. This way, we don't have to load it again when the user decides to boot from HDD.
- Check for the 0xAA55 signature to decide if the HDD contains a valid MBR. This was done differently and inconsistently for isoboot and isobtrt.
- Adapt the file and comment style to ReactOS guidelines. Add meaningful comments to our main code. Remove stuff that was just taken from isolinux.asm, but makes no sense for our version.
- Remove DEBUG_MESSAGES ifdef. There is no chance they can ever fit into the 2K sector with all the added features. Debugging can still happen using Bochs or adding specific messages.

Tested with Bochs, QEMU, VMware, VirtualBox and four real computers.
Many thanks to Hermès for all the helpful suggestions and additional investigations! :)

CORE-12648
https://svn.reactos.org/svn/reactos?vie ... sion=73595
r73595 wrote: Author: cfinck
Date: Tue Jan 24 22:53:20 2017 UTC (16 hours, 31 minutes ago)
Log Message:
[ISOHYBRID]
Import the isohybrid tool from http://repo.or.cz/syslinux.git/tree/138 ... 3a2:/utils

I had to add a lot of glue code (getopt, err/errx/warn/warnx) to get it to compile under all our build platforms Windows, Linux and macOS.
GPT/Mac partition support is disabled at the moment (look for REACTOS_ISOHYBRID_EFI_MAC_SUPPORT), that would need a portable libuuid.
A fix for correctly opening ISOs as binary and not text-mode has been implemented and already sent upstream.

ISOs are not being patched automatically yet due to CORE-12692

CORE-12648

Post Reply

Who is online

Users browsing this forum: No registered users and 16 guests