Reactos's applications don't should use tango icons directly

The place to bring up any design issues, or post your own creations

Moderator: Moderator Team

Post Reply
manuel
Posts: 395
Joined: Thu Jan 28, 2010 11:20 pm
Location: México
Contact:

Reactos's applications don't should use tango icons directly

Post by manuel » Tue Dec 22, 2015 9:30 pm

Hi!

I use reactos's regedit clone as windows's regedit replace (on windows 7), but i have a suggestion to this application. I see that regedit (reactos) use folder tango icon to show the keys in the registry. I think that not is good idea use the tango icon as resource to draw the keys, regedit (reactos) should use the windows folder icon directly.
This may enabled use themes and that reactos (and applications) be more compatible with they, because else the reactos's application always will show the tango icons. If the user setup a theme, and this theme can setup your icons I think the applications not draw the icons correctly.
Greetings.
Image

Nemerian
Posts: 19
Joined: Fri May 30, 2014 7:19 am

Re: Reactos's applications don't should use tango icons dire

Post by Nemerian » Fri Jan 01, 2016 11:56 pm

I second this.

manuel
Posts: 395
Joined: Thu Jan 28, 2010 11:20 pm
Location: México
Contact:

Re: Reactos's applications don't should use tango icons dire

Post by manuel » Mon Jan 04, 2016 5:11 pm

Nemerian wrote:I second this.
thanks :D

Thens1966
Posts: 1
Joined: Wed Aug 24, 2016 10:55 am

Re: Reactos's applications don't should use tango icons dire

Post by Thens1966 » Sun Aug 28, 2016 11:18 am

Nemerian wrote:I second this.
i third to this. suggestions should be prioritize and considered to make phen375 weight loss work more effective.
Last edited by Thens1966 on Wed Nov 02, 2016 11:23 pm, edited 1 time in total.


middings
Posts: 850
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Reactos's applications don't should use tango icons dire

Post by middings » Sun Aug 28, 2016 11:07 pm

I think Manuel wants ReactOS applets such as RegEdit to use the system's icons. Under ReactOS as it currently is, those are the Tango icons. Under Microsoft's versions of a windows OS, those are various sets of Microsoft's proprietary icons.

Manuel appears to suggest that ReactOS's applets should avoid incorporating Tango icons into their own code. Apparently ReactOS's RegEdit applet uses its own copies of Tango icons. Instead, ReactOS applets should obtain their icons using appropriate system calls whenever possible*. Doing this will cause the applet's icons to automatically conform to the system's native icon set.

The benefit of Manuel's suggestion is that ReactOS applets would have a native look and feel under all versions of a windows OS that they support. Manuel anticipates that someday ReactOS's support for themes will be so robust that users could change the system's icon set to one of their own choice.

* perhaps ReactOS's RegEdit applet was written before ReactOS implemented the appropriate system calls

manuel
Posts: 395
Joined: Thu Jan 28, 2010 11:20 pm
Location: México
Contact:

Re: Reactos's applications don't should use tango icons dire

Post by manuel » Mon Aug 29, 2016 1:33 am

I think Manuel wants ReactOS applets such as RegEdit to use the system's icons
The benefit of Manuel's suggestion is that ReactOS applets would have a native look and feel under all versions of a windows OS
exactly, regedit from ReactOS show folder icons but with Tango style, not use Windows icons (from shell32.dll), regedit should draw these icons from shell32.dll too, and shell32.dll contain the tango icons.

reactosfanboy
Posts: 5
Joined: Sun Feb 01, 2015 1:54 pm

Re: Reactos's applications don't should use tango icons dire

Post by reactosfanboy » Tue Aug 30, 2016 11:21 pm

I agree with manuel here.
Using the icons from shell32 would give native look & feel and would furthermore rreduce regedits binary size.

ercanersoy
Posts: 54
Joined: Thu Sep 17, 2015 8:25 pm
Location: Turkey

Re: Reactos's applications don't should use tango icons dire

Post by ercanersoy » Tue Sep 13, 2016 1:58 pm

Tango icons is simple. They looks very good for ReactOS.

dizt3mp3r
Posts: 1097
Joined: Mon Jun 14, 2010 5:54 pm

Re: Reactos's applications don't should use tango icons dire

Post by dizt3mp3r » Tue Sep 13, 2016 2:51 pm

ercanersoy wrote:Tango icons is simple. They looks very good for ReactOS.
Perhaps but that isn't the point.

middings
Posts: 850
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Reactos's applications don't should use tango icons dire

Post by middings » Wed Sep 14, 2016 10:04 am

ercanersoy wrote:Tango icons is simple. They looks very good for ReactOS.
Yes, Tango icons are simple and look very good. Manuel proposes that ReactOS's applications should obtain their icons that the system supports using the usual API calls rather than carrying copies of those icons within the applications themselves. This way, ReactOS's applications would use ReactOS's Tango icons when run in ReactOS and Microsoft's icons when ReactOS's applications are run in a Microsoft Windows environment.

Manuel posted a screen capture of ReactOS's RegEdit running under Microsoft Windows 7. ReactOS's RegEdit uses its own internal copies of common system icons (for example, the folder icon) rather than obtaining them from the system using the usual API calls. Thus, ReactOS's RegEdit looks ok when run under ReactOS but strange when run under other ReactOS-compatible operating systems.

I think that enabling the widespread use of ReactOS components, even in Microsoft Windows environments, is beneficial to the ReactOS Project and to the entire Free and Open Source Software (FOSS) community.

dizt3mp3r
Posts: 1097
Joined: Mon Jun 14, 2010 5:54 pm

Re: Reactos's applications don't should use tango icons dire

Post by dizt3mp3r » Wed Sep 14, 2016 3:43 pm

Someone please change the name of this thread to "Reactos' applications should not hardcode the use of tango icons"

It is driving me nuts! (ubersturmbahngrammarNazi).

middings
Posts: 850
Joined: Tue May 07, 2013 9:18 pm
Location: California, USA

Re: Reactos's applications don't should use tango icons dire

Post by middings » Wed Sep 14, 2016 10:33 pm

I agree.
Shorter alternatives:

Code: Select all

ReactOS applications: avoid hardcoded Tango icons
Do not hardcode Tango icons in ReactOS applications
Avoid hardcoded Tango icons in ReactOS applications
ReactOS applications must avoid hardcoded Tango icons

Post Reply

Who is online

Users browsing this forum: EmuandCo and 7 guests