steps for a pull request
Posted: Sun May 12, 2019 6:09 pm
Okay. Step by step we'll get to the destination.
I've created a branch at https://github.com/zecarlos1957/reactos ... nslactions.
After compiling and testing the desired changes in the virtualbox, i insert into this branch.
But I want to put these changes into discussion and review with others, so I click on "create pull request".
An edit box appears with some fields to fill.
One of them:
JIRA issue: [CORE-XXXX] (https://jira.reactos.org/browse/CORE-XXXX)
There is no name space in this edit box.
Also when creating an issue in the jira there is no place to name.
Here are my problems, because Contributors are asked to use the full name when creating a commit
and I do not see where I should put the name.
Should I create an issue in the jira to create
a pull request on GitHub?
Thank you for your attention
I've created a branch at https://github.com/zecarlos1957/reactos ... nslactions.
After compiling and testing the desired changes in the virtualbox, i insert into this branch.
But I want to put these changes into discussion and review with others, so I click on "create pull request".
An edit box appears with some fields to fill.
One of them:
JIRA issue: [CORE-XXXX] (https://jira.reactos.org/browse/CORE-XXXX)
There is no name space in this edit box.
Also when creating an issue in the jira there is no place to name.
Here are my problems, because Contributors are asked to use the full name when creating a commit
and I do not see where I should put the name.
Should I create an issue in the jira to create
a pull request on GitHub?
Thank you for your attention