Page 1 of 1

Diskpart Maintainer

Posted: Tue Jul 02, 2019 11:24 am
by Gaprosys
Hello,

first, you're all doing a great job and I think this project is really great.

For over a year, I've been happy to read the news, closed Jira tickets and the latest changes in the wiki.

All the people around ReactOS are doing a great job, and the progress ReactOS has made after setting the development to a 3-month release cycle is breathtaking.

I hope to see more of the people around ReactOS see what's going on and how the project will evolve in the future.

Ever since I got to know this project, I wanted to get involved and develop diskpart as far as I could. Is the diskpart currently being actively developed by someone, or is there a maintainer for diskpart?

Yours sincerely,

- Gaprosys

Re: Diskpart Maintainer

Posted: Tue Jul 02, 2019 2:21 pm
by gonzoMD
AFAIK there is no maintainer nor it is actively developed. Just fork the repo, start coding and send a pull request.

Happy coding!

Re: Diskpart Maintainer

Posted: Tue Jul 02, 2019 2:32 pm
by Gaprosys
gonzoMD, thanks for your answer.

Then I can just start off.

Re: Diskpart Maintainer

Posted: Tue Jul 02, 2019 2:46 pm
by hbelusca
Here is the explanation how it should go (since the aim of ReactOS is to re-implement NT architecture in an open-source manner):
https://docs.microsoft.com/en-us/previo ... 2(v=ws.10)
[ external image ]

Re: Diskpart Maintainer

Posted: Tue Jul 02, 2019 5:06 pm
by erkinalp
Note that bootcfg and bcdedit are absent in ReactOS.

Re: Diskpart Maintainer

Posted: Tue Jul 02, 2019 10:40 pm
by Gaprosys
Thanks for your replys.

I have a look into the documentation from Microsoft.

Re: Diskpart Maintainer

Posted: Tue Aug 06, 2019 3:44 pm
by Gaprosys
I read now through the documentation and got to learn a little bit over vds.

I'm now trying to run the files, from vds and the corresponding files in reactos. I took the files from windows server 2003 and copied it into the virtual machine with reactos installed.

vds.exe seams to run just fine, but if I try to run the diskpart.exe from Windows Server 2003, diskpart says "The disk management services could not complete the operation."

For now, I want to look into this, to check, if APIs are missing, that VDS need to run correctly or why VDS doesn't seam to run fine.
How could I go and do this?

Re: Diskpart Maintainer

Posted: Wed Aug 07, 2019 3:03 pm
by karlexceed
Time to break out the debugging tools. The simplest place to start would be to attach a serial monitor to your VM and run ReactOS in Debug mode when you do this testing.

I'd start here: https://reactos.org/wiki/Debugging#Virtual_machines

Beyond that you may need to use tools like Windbg, but there are others here who can help you with how to use tools like that more than I could.

Re: Diskpart Maintainer

Posted: Thu Aug 08, 2019 7:48 am
by Gaprosys
Thanks you for your quick reply, karlexceed.

With a little thought, I could have come up with the debugging tools myself.

Anyway, thank you very much for getting me in that direction.

Have a nice day.

- Gaprosys

Re: Diskpart Maintainer

Posted: Mon Aug 19, 2019 4:10 pm
by Gaprosys
With the help of karlexceed I used the debug-mode from ReactOS and found the solutions, that registry-keys are missing.

If I start now VDS as a service putty gives me the following output:

Code: Select all

(win32ss/user/ntuser/nonclient.c:1063) err: Wnd is active and not set active!
(dll/ntdll/rtl/version.c:62) We modified the reported OS from NtProductServer to NtProductWinNt
(dll/ntdll/rtl/version.c:62) We modified the reported OS from NtProductServer to NtProductWinNt
fixme:(dll/win32/ole32/compobj.c:4042) (0047FF40,-1,00000000,00000000,6,2,00000000,8194,00000000) - stub!
I know that the second and third line are coming, because I declared my VM as Workstation, instead as Server.

If I now run diskpart.exe from the Windows 2003-Server the following lines are coming:

Code: Select all

(dll/ntdll/rtl/version.c:62) We modified the reported OS from NtProductServer to NtProductWinNt
(dll/ntdll/rtl/version.c:62) We modified the reported OS from NtProductServer to NtProductWinNt
fixme:(dll/win32/ole32/compobj.c:4042) (00000000,-1,00000000,00000000,6,2,00000000,0,00000000) - stub!
(dll/ntdll/rtl/version.c:62) We modified the reported OS from NtProductServer to NtProductWinNt
fixme:(dll/win32/ole32/compobj.c:4042) (00000000,-1,00000000,00000000,6,2,00000000,8194,00000000) - stub!
fixme:(dll/win32/ole32/compobj.c:3202) stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (0006ED7C, 0006E970, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (0077FB70, 0077F76C, 1024, 0x0): semi-stub
fixme:(dll/win32/ole32/compobj.c:3319) () non-NULL pServerInfo not supported!
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (0077F518, 0077F10C, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (007CFB70, 007CF76C, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (007CFB70): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (0077F518): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (0077FB70): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (0006ED7C): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (0006ED7C, 0006E970, 1024, 0x0): semi-stub
(win32ss/user/ntuser/class.c:1041) err: Failed to register class atom!
(win32ss/user/ntuser/class.c:1541) err: UserRegisterClass: Yes, that is right, you have no Class!
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (007CFB70, 007CF76C, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (007CFB70): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (0006ED7C): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (0006EDD0, 0006E9C4, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7229) (007CFB70, 007CF76C, 1024, 0x0): semi-stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (007CFB70): stub
fixme:(dll/win32/rpcrt4/ndr_marshall.c:7267) (0006EDD0): stub
fixme:(dll/win32/atl/atl30.c:281) 01027468
err:(dll/win32/ole32/marshal.c:1921) IMarshal::ReleaseMarshalData failed with error 0x8001011d
(base/system/services/database.c:440) ScmRemoveServiceImage() called
fixme:(dll/win32/ole32/compobj.c:4058)
fixme:(dll/win32/atl/atl30.c:281) 01004080
err:(dll/win32/ole32/marshal.c:1921) IMarshal::ReleaseMarshalData failed with error 0x8001011d
Does I missing some extra Registry-Keys or what is the problem, with the UserRegisterClass?

I use now the 0.4.11 codebase to research the vds, so this lines-numbers are from the 0.4.11 code.

If someone still needs the registry keys that I found so far, they can write that and I would be happy to post the found keys.

Yours sincerely,

- Gaprosys