Difference between revisions of "Submitting Patches"
Colin Finck (talk | contribs) (Cleanup) |
(→Preparing the patch) |
||
| Line 9: | Line 9: | ||
== Preparing the patch == | == Preparing the patch == | ||
| − | Make sure that your patch is against the latest code from SVN. Where you have made changes to an existing source file, you have to use the ''diff'' function of your SVN client to obtain a file that contains only the changes that you have made. | + | Make sure that your patch is against the latest code from SVN. Where you have made changes to an existing source file, you have to use the ''diff'' function of your SVN client to obtain a file that contains only the changes that you have made. If possible, make the diff starting in root directory to preserve path information of changed files. Please create '''one''' patch file only, even for multiple files (new ones as well) as long as they belongs to one change. |
Also make sure that you have installed an SVN client. The page [[Subversion#Access_the_sources|Subversion - Access the sources]] gives you more information about getting an SVN client for your operating system. | Also make sure that you have installed an SVN client. The page [[Subversion#Access_the_sources|Subversion - Access the sources]] gives you more information about getting an SVN client for your operating system. | ||
Revision as of 09:00, 6 August 2008
Since ReactOS does not have a definite maintainer for each section of the code, you should file a new bug in Bugzilla and apply your patch. Set the severity level to major to draw the developers attention to the patch. If you are unsure about something, talk to a developer in the #reactos IRC Channel.
Contents
Test your patch
Thoroughly check that your change works as intended.
Test your changes with the latest code from SVN. Something may have changed in the latest revision that either breaks your change or causes your change to break something else. Make sure that ReactOS can still boot and that any application or system that may be affected by your change still runs properly.
Preparing the patch
Make sure that your patch is against the latest code from SVN. Where you have made changes to an existing source file, you have to use the diff function of your SVN client to obtain a file that contains only the changes that you have made. If possible, make the diff starting in root directory to preserve path information of changed files. Please create one patch file only, even for multiple files (new ones as well) as long as they belongs to one change.
Also make sure that you have installed an SVN client. The page Subversion - Access the sources gives you more information about getting an SVN client for your operating system.
Then read the section Creating a patch/diff file of the usage page for your SVN client.
All these usage pages are listed here: Subversion - Usage of the SVN clients.
Attaching the patch to the bug report
If your changes are all in one patch file, you can simply attach the patch file to the bug report. Don't forget to tick the check box patch when attaching the file to indicate that this is a patch file.
If your changes can't be stored in just one patch file (for example binary files can't be stored in patch files), create a ZIP file containing your new files and attach it to the bug report.
Other information
- You need to provide your name and mail address!
Patches from unknown authors are not accepted!!!
