[ros-kernel] Progress bar border

[Richard Campbell]

I will fix the issue once i'm clear on what the actual issue is :)

Sorry for the hardheadedness, coding is limited to early morning 
4am-5am, anyways, so is the WS_EX_STATICEDGE style automatically added 
to a progress bar on creation?  It is present even if WS_EX_STATICEDGE 
isn't used, and WS_EX_STATICEDGE is handled by user32 anyways.  Sorry 
for making such a major gripe out of such a minor issue, i'm merely 
attempting to improve the UI before the next release, speaking of which, 
when IS the next release?

Filip Navara wrote:

>The typical border you see on progress bars is created using
>WS_EX_STATICEDGE style. If no one will fix this issue first, I'll
>take a look at it after finishing my current work on pattern
>brushes.
>
>- Filip
>
>----- PŮVODNÍ ZPRÁVA -----
>Od: "Richard Campbell" <eek2121 at comcast.net>
>Komu: "ReactOS Kernel List" <ros-kernel at reactos.com>
>Předmět: Re: [ros-kernel] Progress bar border
>Datum: 5.4.2004 - 11:38:18
>
>  
>
>>Change reverted, however wine DOES draw a border
>>(FrameRect is called, 
>>border isn't visible because of an off by one issue?)
>>in PROGRESS_draw.  
>>That is why i had put this code there.
>>
>>Ge van Geldorp wrote:
>>
>>    
>>
>>>>From: Richard Campbell
>>>>
>>>>Are you sure the border in this case isn't progress
>>>>bar 
>>>>specific?  There isn't a flag to determine whether
>>>>this
>>>>border is displayed, the way you suggest would be to
>>>>just draw the border for EVERY control in WM_NCPAINT,
>>>>which is incorrect, or am i misunderstanding you?
>>>>   
>>>>
>>>>        
>>>>
>>>I haven't looked at the code, but the progress bar is
>>>a direct port from
>>>Wine. Wine does draw the border correctly when needed
>>>without your
>>>change to progress.c, so there must be another way.
>>>We will never get your change accepted into Wine and
>>>to keep
>>>synchronizing between the Wine tree and our own tree
>>>as simple as
>>>possible I would very much welcome it if your change
>>>could be reverted.
>>>
>>>Gé van Geldorp.
>>>
>>>
>>>
>>>_______________________________________________
>>>Ros-kernel mailing list
>>>Ros-kernel at reactos.com
>>>http://reactos.com/mailman/listinfo/ros-kernel
>>>
>>> 
>>>
>>>      
>>>
>>_______________________________________________
>>Ros-kernel mailing list
>>Ros-kernel at reactos.com
>>http://reactos.com/mailman/listinfo/ros-kernel
>>
>>    
>>
>
>  
>