[ros-kernel] RE: [ros-cvs] CVS Update: reactos

[Eric Kohl]

"Hartmut Birr" <Hartmut.Birr at gmx.de> wrote:
> Hi,
>
> you added new prototypes or stubs to the ros source. I've not found any
> public informations about many of this functions. In some declarations,
the
> types of the parameters are out-commanded and replaced with VOID. Over
this
> types is also no public information available. This is suspicious for me.
> Please explain from where your informations comes.
>
> - Hartmut

I'd also like to add that a lot of functions were obviously placed in the
wrong files. For example, KiIpiServiceRoutine() does not belong into
ntoskrnl/ke/dpc.c because it is no DPC function but is a multiprocessor
support routine (IPI = Interprocessor Interrupt, see Intel MP
specification).

A lot of stubs and prototypes look like they were cut & pasted from MS
headers because they use exactly the same indentation. We cannot accept such
contributions as they violate Microsofts copyright!

Finally I'd like to mention that several prototypes were place in internal
header files although they belong into the ddk headers.


Please stop adding stubs because you are wasting your time an the time of
those who have to clean-up the mess.


Regards,
Eric Kohl